Review main Merged

49865[TASK] Fluidification of Avatar.php

Marc Willmann CR +2 V +2 Normal +51 −3 updated 10/24/16, 17:13

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Marco Bresch +1
  • Verified V +2
    • Jan Helke +2
    • Marco Bresch +1

Issues 1

Files 2

Review log 1316

  1. Marc Willmann uploaded patch set 1 09/05/16, 12:31

  2. TYPO3com voted on patch set 1 V +1 09/05/16, 12:35 Completed build in 03m 01s on Mon, 5 Sep, 02:35 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-2986

  3. Marc Willmann commented on patch set 1 09/05/16, 12:35

    Avatar.php:61

    This property is marked as "internal". Is there a better way to do this?
  4. Frank Nägler commented on patch set 1 CR -2 09/07/16, 14:57

    Hello Marc, thanks for your patch. I have one problem with your patch. You add a lot of PHP code to remove two lines of HTML. I discusses this with lolli and we decided to ask the rest of the core team about this kind of patches. Please stay tuned
  5. Marc Willmann commented on patch set 1 09/07/16, 15:01

    Frank, you're right. A suggestion I already discussed with Jan Helke is to put the (more than once needed) method getFluidTemplateObject to some Utitlities class. This would save some code and could be a way to handle this?
  6. Frank Nägler voted on patch set 1 CR 0 10/24/16, 15:06

  7. Jan Helke commented on patch set 1 CR -1 10/24/16, 15:37

    Marc is working on it.
  8. Marc Willmann uploaded patch set 2 10/24/16, 15:49

  9. TYPO3com voted on patch set 2 V +1 10/24/16, 15:55 Completed build in 06m 13s on Mon, 24 Oct, 05:55 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4072

  10. Jan Helke voted on patch set 2 CR +1 V +1 10/24/16, 16:42

  11. Marco Bresch commented on patch set 3 10/24/16, 17:04

    Published edit on patch set 2.
  12. Marco Bresch voted on patch set 3 CR +1 10/24/16, 17:04

  13. Marco Bresch voted on patch set 3 V +1 10/24/16, 17:07

  14. Jan Helke voted on patch set 3 CR +2 V +2 10/24/16, 17:09

  15. Gerrit merged patch set 3 10/24/16, 17:09

  16. TYPO3com commented on patch set 3 10/24/16, 17:13 Completed build in 09m 10s on Mon, 24 Oct, 07:13 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4081