4987[BUGFIX] Alignment issue in "View Item" window
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Steffen Gebert +1
-
Verified V +2
- Helmut Hummel +2
- Steffen Gebert +1
Issues 1
Files 2
Review log 8
-
Helmut Hummel commented on patch set 2 V 0 09/17/11, 18:13
by team member; Looks good to me, approved -
Steffen Gebert uploaded patch set 2 09/17/11, 18:13
-
Steffen Gebert commented on patch set 2 09/17/11, 18:13
Verified; Looks good to me, but someone else must approve -
Jigal van Hemert commented on patch set 1 09/17/11, 18:13
(2 inline comments)Typo in 'Alignment'Which branch(es)? Very minor: wiki says to use 'Fixes:' for bugfixesshow_item.php:326If a line is modified, please also fix CGL issues (spaces around dot operators, etc.)show_item.php:329CGL tooelement_infopopup.css:23extra whitespace at the beginning of the line. And why the empty CSS definition? -
Jigal van Hemert commented on patch set 1 09/17/11, 18:13
(3 inline comments) I'm not sure what's the problem with this patch, but if I fetch it my working directories show severe problems. I lose access to directories, have to reboot and git reset --hard to fix it again. Tried a few other patches and they work without a problem. -
Mr. Jenkins commented on patch set 1 09/17/11, 18:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1861/ : SUCCESS -
Mr. Jenkins commented on patch set 2 09/17/11, 18:13
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/1873/ : SUCCESS -
Helmut Hummel merged patch set 2 09/17/11, 18:13