Review main Merged

4987[BUGFIX] Alignment issue in "View Item" window

Tomas Norre Mikkelsen CR +2 V +2 Easy +12 −3 updated 06/03/13, 20:49

Commit message

The file name and dimension information need some space for better
separation in the "View Item" window.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Steffen Gebert +1
  • Verified V +2
    • Helmut Hummel +2
    • Steffen Gebert +1

Issues 1

Files 2

Review log 8

  1. Helmut Hummel commented on patch set 2 V 0 09/17/11, 18:13

    by team member; Looks good to me, approved
  2. Steffen Gebert uploaded patch set 2 09/17/11, 18:13

  3. Steffen Gebert commented on patch set 2 09/17/11, 18:13

    Verified; Looks good to me, but someone else must approve
  4. Jigal van Hemert commented on patch set 1 09/17/11, 18:13

    (2 inline comments)
    Typo in 'Alignment'
    Which branch(es)? Very minor: wiki says to use 'Fixes:' for bugfixes

    show_item.php:326

    If a line is modified, please also fix CGL issues (spaces around dot operators, etc.)

    show_item.php:329

    CGL too

    element_infopopup.css:23

    extra whitespace at the beginning of the line. And why the empty CSS definition?
  5. Jigal van Hemert commented on patch set 1 09/17/11, 18:13

    (3 inline comments) I'm not sure what's the problem with this patch, but if I fetch it my working directories show severe problems. I lose access to directories, have to reboot and git reset --hard to fix it again. Tried a few other patches and they work without a problem.
  6. Mr. Jenkins commented on patch set 1 09/17/11, 18:13

  7. Mr. Jenkins commented on patch set 2 09/17/11, 18:13

  8. Helmut Hummel merged patch set 2 09/17/11, 18:13