Review main Abandoned

49894[TASK] Acceptance test for site name in backend

Eugene Kenah Djomo CR 0 V 0 Easy +40 −0 updated 10/25/16, 22:18

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1013

  1. Eugene Kenah Djomo uploaded patch set 1 09/09/16, 13:10

  2. TYPO3com voted on patch set 1 V -1 09/09/16, 13:14 Completed build in 03m 30s on Fri, 9 Sep, 03:14 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3035

  3. Jan Helke uploaded patch set 2 10/07/16, 12:48

  4. TYPO3com voted on patch set 2 V +1 10/07/16, 12:52 Completed build in 03m 05s on Fri, 7 Oct, 02:51 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3374

  5. Michał Jankiewicz uploaded patch set 3 10/09/16, 09:30

  6. TYPO3com voted on patch set 3 V +1 10/09/16, 09:35 Completed build in 04m 48s on Sun, 9 Oct, 11:35 AM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3506

  7. Michał Jankiewicz voted on patch set 3 CR +1 V +1 10/09/16, 10:09

  8. Jan Helke commented on patch set 3 10/09/16, 10:34

    Can somebody explain to me what this test is needed for? It basically checks only if the element is there.
  9. Jan Helke commented on patch set 3 10/09/16, 10:36

    But what is the higher meaning behind that? Because otherwise we could also test for the existence of every HTML element in the backend.
  10. Michał Jankiewicz commented on patch set 3 CR 0 V 0 10/09/16, 10:48

    I see just one meaning. It checks that backend is up. But you're right.
  11. Daniel Gohlke commented on patch set 3 CR -1 10/24/16, 17:40

    Test only looks for a class not for the site name.
  12. Christian Kuhn commented on patch set 3 10/25/16, 22:18

    ok, there is no real point in this test - the main functionality of the backend is tested by all the other tests anyway ... i'll abandon this one for now.
  13. Christian Kuhn abandoned the change 10/25/16, 22:18