Review main Merged

49896[TASK] Fluidification of TypoScriptTemplateObjectBrowserModuleFunctionController

Marco Bresch CR +2 V +2 Hard +288 −155 updated 10/06/16, 09:34

Commit message

Move all HTML from PHP code to an own Fluid template.

Review

  • Code review CR +2
    • Jan Helke +2
    • Jörg Bösche +1
    • Michael Oehlhof +1
  • Verified V +2
    • Jan Helke +2
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1620

  1. Marco Bresch uploaded patch set 1 09/09/16, 16:08

  2. Marco Bresch commented on patch set 1 CR -1 V -1 09/09/16, 16:09

    Try to finish this next week.
  3. TYPO3com voted on patch set 1 V -1 09/09/16, 16:12 Completed build in 03m 28s on Fri, 9 Sep, 06:12 PM Test Summary: 18507 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3044

  4. Marco Bresch uploaded patch set 2 09/13/16, 15:58

  5. TYPO3com voted on patch set 2 V +1 09/13/16, 16:02 Completed build in 03m 36s on Tue, 13 Sep, 06:02 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3070

  6. Michael Oehlhof commented on patch set 2 CR -1 09/14/16, 07:54

    TemplateObjectBrowserModuleFunction.html:229

    This looks like test output and should be removed.
  7. Michael Oehlhof uploaded patch set 3 09/14/16, 08:20

  8. Michael Oehlhof voted on patch set 3 CR +1 V +1 09/14/16, 08:21

  9. TYPO3com voted on patch set 3 V +1 09/14/16, 08:23 Completed build in 03m 11s on Wed, 14 Sep, 10:23 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3083

  10. Oliver Klee commented on patch set 3 09/14/16, 12:42

    locallang_objbrowser.xlf:73

    As this is an XML file, shouldn't the quotes be encoded as "?
  11. Marco Bresch commented on patch set 3 09/14/16, 15:27

    locallang_objbrowser.xlf:73 Reply

    Well I discussed this with Frank Nägler. We agreed that htmlentities should not used in locallang-files. Because we don't know where that label is used. Maybe it is a output in json or html or whatever.
  12. Oliver Klee commented on patch set 3 09/14/16, 15:32

    I think you've misunderstood me. As this is an XML file, having &quot; in the file will result in " when reading it (so no entity anymore). It's just proper encoding (the same way you would encode < as &lt; or by putting it in CDATA).
  13. Marco Bresch commented on patch set 3 09/14/16, 15:34

    Uh... Ah... I see... I will check this.
  14. Marco Bresch uploaded patch set 4 09/14/16, 16:00

  15. Marco Bresch commented on patch set 4 09/14/16, 16:02

    Thanks for this hint, Oliver! You are right.
  16. TYPO3com voted on patch set 4 V +1 09/14/16, 16:04 Completed build in 03m 34s on Wed, 14 Sep, 06:04 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3085

  17. Michael Oehlhof voted on patch set 4 CR +1 V +1 09/14/16, 21:58

  18. Jörg Bösche voted on patch set 4 CR +1 09/23/16, 10:03

  19. Jan Helke voted on patch set 4 CR +2 V +2 10/06/16, 09:34

  20. Gerrit merged patch set 4 10/06/16, 09:34