49934[!!!][TASK] Deprecate the field select_key of tt_content
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/View/PageLayoutView.php4+0 −3
- typo3/sysext/compatibility7/Configuration/TCA/Overrides/tt_content.php+17 −1
- typo3/sysext/compatibility7/ext_tables.sql+7 −0
- typo3/sysext/context_help/Resources/Private/Language/locallang_csh_ttcontent.xlf+0 −10
- typo3/sysext/core/Documentation/Changelog/master/Breaking-77934-RemoveSelectKeyFromContentElementPreview.rstnew+32 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-77934-DeprecateTt_contentFieldSelect_key.rstnew+32 −0
- typo3/sysext/css_styled_content/Configuration/TCA/Overrides/tt_content.php+0 −1
- typo3/sysext/css_styled_content/Configuration/TypoScript/v7/setup.txt+1 −4
- typo3/sysext/css_styled_content/static/setup.txt+1 −4
- typo3/sysext/css_styled_content/Tests/Functional/Tca/ContentVisibleFieldsTest.php+0 −1
- typo3/sysext/fluid_styled_content/Configuration/TypoScript/ContentElement/List.txt+1 −1
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −10
- typo3/sysext/frontend/Tests/Functional/Tca/ContentVisibleFieldsTest.php+0 −1
- typo3/sysext/frontend/ext_tables.sql+0 −1
- typo3/sysext/indexed_search/Configuration/TCA/Overrides/tt_content.php+2 −2
- typo3/sysext/t3editor/Resources/Public/JavaScript/parse_typoscript/tokenizetyposcript.js+0 −1
Review log 1623
-
Georg Ringer uploaded patch set 1 09/13/16, 18:13
-
TYPO3com voted on patch set 1 V +1 09/13/16, 18:16 Completed build in 03m 09s on Tue, 13 Sep, 08:16 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3072
-
Markus Klein commented on patch set 1 09/20/16, 12:23
-
Georg Ringer commented on patch set 1 09/20/16, 12:36
PageLayoutView.php:1820Replynothing breaks just because that is not there anymore! furthermore this was only shown if list_type is empty which is really not often -
Markus Klein commented on patch set 1 09/20/16, 12:43
PageLayoutView.php:1820ReplyIt is there again if comp7 is installed. For a real deprecation we must not break anything. -
Markus Klein commented on patch set 1 CR -1 10/28/16, 11:28
I'm +1 for getting rid of the field nowadays, still this is a breaking change as a whole. -
Anja Leichsenring commented on patch set 1 CR -1 12/04/16, 11:11
this is somehow related to https://review.typo3.org/#/c/50793, so how to proceed here? The field must not be removed, that would be a breaking change. -
Georg Ringer uploaded patch set 2 01/02/17, 08:08
-
TYPO3com voted on patch set 2 V -1 01/02/17, 08:12 Completed build in 04m 01s on Mon, 2 Jan, 09:12 AM Test Summary: 4 of 54437 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6144
-
Georg Ringer uploaded patch set 3 01/02/17, 08:15
-
TYPO3com voted on patch set 3 V +1 01/02/17, 08:21 Completed build in 05m 54s on Mon, 2 Jan, 09:21 AM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6146
-
Markus Klein updated the commit message in patch set 4 01/03/17, 10:36
-
Markus Klein commented on patch set 4 01/03/17, 10:38
PageLayoutView.php:1794this is IMO a breaking change. The select_key, if present is not shown anymore. Should comp7 provide a hook for that?tt_content.php:10layout, pages has to stay -
TYPO3com voted on patch set 4 V +1 01/03/17, 10:40 Completed build in 04m 19s on Tue, 3 Jan, 11:40 AM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6172
-
Georg Ringer uploaded patch set 5 01/09/17, 18:41
-
TYPO3com voted on patch set 5 V +1 01/09/17, 18:46 Completed build in 04m 24s on Mon, 9 Jan, 07:46 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6350
-
Georg Ringer uploaded patch set 6 01/26/17, 21:34
-
TYPO3com voted on patch set 6 V +1 01/26/17, 21:38 Completed build in 04m 45s on Thu, 26 Jan, 10:38 PM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7086
-
Christian Kuhn updated the commit message in patch set 7 01/27/17, 09:48
-
Christian Kuhn voted on patch set 7 CR +1 V +1 01/27/17, 09:48
-
TYPO3com voted on patch set 7 V +1 01/27/17, 09:52 Completed build in 04m 29s on Fri, 27 Jan, 10:52 AM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7096
-
Benni Mack voted on patch set 7 CR +2 V +2 01/27/17, 11:10
-
Gerrit merged patch set 7 01/27/17, 11:10
PageLayoutView.php:1820