Review main Merged Breaking

49934[!!!][TASK] Deprecate the field select_key of tt_content

Georg Ringer CR +2 V +2 Normal +93 −40 updated 01/27/17, 11:10

Commit message

The field `select_key` is not used by the core and
is moved to the EXT:compatibility7.

Review

  • Code review CR +2
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1623

  1. Georg Ringer uploaded patch set 1 09/13/16, 18:13

  2. TYPO3com voted on patch set 1 V +1 09/13/16, 18:16 Completed build in 03m 09s on Tue, 13 Sep, 08:16 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3072

  3. Markus Klein commented on patch set 1 09/20/16, 12:23

    PageLayoutView.php:1820

    removing this is breaking and not a deprecation anymore, IMHO.
  4. Georg Ringer commented on patch set 1 09/20/16, 12:36

    PageLayoutView.php:1820 Reply

    nothing breaks just because that is not there anymore! furthermore this was only shown if list_type is empty which is really not often
  5. Markus Klein commented on patch set 1 09/20/16, 12:43

    PageLayoutView.php:1820 Reply

    It is there again if comp7 is installed. For a real deprecation we must not break anything.
  6. Markus Klein commented on patch set 1 CR -1 10/28/16, 11:28

    I'm +1 for getting rid of the field nowadays, still this is a breaking change as a whole.
  7. Anja Leichsenring commented on patch set 1 CR -1 12/04/16, 11:11

    this is somehow related to https://review.typo3.org/#/c/50793, so how to proceed here? The field must not be removed, that would be a breaking change.
  8. Georg Ringer uploaded patch set 2 01/02/17, 08:08

  9. TYPO3com voted on patch set 2 V -1 01/02/17, 08:12 Completed build in 04m 01s on Mon, 2 Jan, 09:12 AM Test Summary: 4 of 54437 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6144

  10. Georg Ringer uploaded patch set 3 01/02/17, 08:15

  11. TYPO3com voted on patch set 3 V +1 01/02/17, 08:21 Completed build in 05m 54s on Mon, 2 Jan, 09:21 AM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6146

  12. Markus Klein updated the commit message in patch set 4 01/03/17, 10:36

  13. Markus Klein commented on patch set 4 01/03/17, 10:38

    PageLayoutView.php:1794

    this is IMO a breaking change. The select_key, if present is not shown anymore. Should comp7 provide a hook for that?

    tt_content.php:10

    layout, pages has to stay
  14. TYPO3com voted on patch set 4 V +1 01/03/17, 10:40 Completed build in 04m 19s on Tue, 3 Jan, 11:40 AM Test Summary: 54437 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6172

  15. Georg Ringer uploaded patch set 5 01/09/17, 18:41

  16. TYPO3com voted on patch set 5 V +1 01/09/17, 18:46 Completed build in 04m 24s on Mon, 9 Jan, 07:46 PM Test Summary: 54921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6350

  17. Georg Ringer uploaded patch set 6 01/26/17, 21:34

  18. TYPO3com voted on patch set 6 V +1 01/26/17, 21:38 Completed build in 04m 45s on Thu, 26 Jan, 10:38 PM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7086

  19. Christian Kuhn updated the commit message in patch set 7 01/27/17, 09:48

  20. Christian Kuhn voted on patch set 7 CR +1 V +1 01/27/17, 09:48

  21. TYPO3com voted on patch set 7 V +1 01/27/17, 09:52 Completed build in 04m 29s on Fri, 27 Jan, 10:52 AM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7096

  22. Benni Mack voted on patch set 7 CR +2 V +2 01/27/17, 11:10

  23. Gerrit merged patch set 7 01/27/17, 11:10