Review main Merged

49937[BUGFIX] Support target in ctype uploads and fluid_styled_content

Georg Ringer CR +2 V +2 Easy +2 −2 updated 09/21/16, 08:14

Commit message

The target configuration of the filelink plugin must be considered
if using fluid_styled_content.

Review

  • Code review CR +2
    • Markus Klein +2
    • Riccardo De Contardi +1
  • Verified V +2
    • Markus Klein +2
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Georg Ringer uploaded patch set 1 09/14/16, 06:25

  2. TYPO3com voted on patch set 1 V +1 09/14/16, 06:28 Completed build in 03m 36s on Wed, 14 Sep, 08:28 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3081

  3. Josef Glatz voted on patch set 1 CR +1 09/15/16, 07:55

  4. Markus Klein commented on patch set 2 09/20/16, 12:15

    Published edit on patch set 1.
  5. Markus Klein voted on patch set 2 CR +1 09/20/16, 12:15

  6. TYPO3com voted on patch set 2 V +1 09/20/16, 12:18 Completed build in 03m 12s on Tue, 20 Sep, 02:18 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3144

  7. Riccardo De Contardi commented on patch set 2 CR +1 V +1 09/21/16, 07:44

    works fine. The only issue (IMO not related) I found during test was that the "target" dropdown has 2 values in BE: one is "new window" (_blank), but the other one (no target) has no label, so it seems an error
  8. Markus Klein voted on patch set 2 CR +2 V +2 09/21/16, 08:14

  9. Gerrit merged patch set 2 09/21/16, 08:14