49943[BUGFIX] Prevent exception due to missing id in the language menu
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Andreas Kienast +1
- Michael Oehlhof +1
- Andreas Bouche +1
- Frederic Gaus +1
- anonymized-54557 +1
- Stephan Großberndt +1
-
Verified V +2
- Xavier Perseguers +2
- Andreas Bouche +1
- Frederic Gaus +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 4551
Show 2226 earlier messages
-
Sascha Nowak uploaded patch set 1 09/15/16, 12:08
-
TYPO3com voted on patch set 1 V +1 09/15/16, 12:12 Completed build in 03m 21s on Thu, 15 Sep, 02:12 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3087
-
Gregor Sievert voted on patch set 1 CR +1 09/15/16, 12:20
-
Stephan Großberndt updated the commit message in patch set 2 09/15/16, 15:56
-
TYPO3com voted on patch set 2 V +1 09/15/16, 16:00 Completed build in 03m 21s on Thu, 15 Sep, 06:00 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3090
-
Wouter Wolters commented on patch set 2 09/15/16, 16:31
Releases line is still missing -
Stephan Großberndt updated the commit message in patch set 3 09/15/16, 16:33
-
TYPO3com voted on patch set 3 V +1 09/15/16, 16:36 Completed build in 03m 23s on Thu, 15 Sep, 06:36 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3091
-
Markus Klein updated the commit message in patch set 4 09/15/16, 20:47
-
TYPO3com voted on patch set 4 V +1 09/15/16, 20:50 Completed build in 03m 13s on Thu, 15 Sep, 10:50 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3094
-
Markus Klein commented on patch set 4 09/15/16, 20:55
AbstractMenuContentObject.php:671IMO this is breaking if you want the id included and do NOT use .exclude in the config. The id would be overwritten. -
Sascha Nowak commented on patch set 4 09/15/16, 21:01
AbstractMenuContentObject.php:671ReplyCould you provide me a usecase for that? When would you have a different id parameter in the query string when you build a language menu for the current page? -
Stephan Großberndt commented on patch set 4 09/15/16, 21:15
there might be a special configuration to use another page id for a language instead of the current. so this is breaking. maybe analyse $getvars after it got filled and add id param if not set then? currently on mobile, cant look into the code. -
Markus Klein commented on patch set 4 09/15/16, 21:17
AbstractMenuContentObject.php:671ReplyI don't have a current usecase for that. This is just pure code analysis by reading. I never used that language menu personally, so I'm not aware of its features. If you say this is a non-usecase I'm fine with that, no problem. -
Sascha Nowak commented on patch set 4 09/16/16, 06:56
@Stephan Großberndt: The same id parameter is used for the page overlay, so it should be the same id as the id in the query string. If you manipulate the query string after tsfe was initialised then you would create a link to a page that may not have the translation. So I think this is not breaking at all. -
Stephan Großberndt commented on patch set 4 09/16/16, 08:09
sounds reasonable. I had problems upgrading 6.2 sites in some cases because they had addQueryString.exclude = id, L, cHash where I do not know why this was set by someone. -
Stephan Großberndt voted on patch set 4 CR +1 09/27/16, 09:06
-
Thorsten Lübkemann commented on patch set 4 09/27/16, 09:22
AbstractMenuContentObject.php:671ReplyShouldn't it be $GLOBALS['TSFE'] instead of $tsfe? -
Wouter Wolters commented on patch set 4 09/27/16, 09:45
AbstractMenuContentObject.php:671Reply$tsfe is $GLOBALS['TSFE'] which is retrieved on line 647 with a getter. -
Thorsten Lübkemann voted on patch set 4 V +1 09/27/16, 09:54
-
Jérémie Roulin voted on patch set 4 CR -1 V -1 09/30/16, 07:56
-
Jérémie Roulin voted on patch set 4 CR +1 V +1 09/30/16, 08:13
-
Ludovic Nogueira voted on patch set 4 CR +1 V +1 09/30/16, 08:13
-
Dmitry Dulepov commented on patch set 4 CR -1 09/30/16, 11:30
I do not think this is needed. See here: https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L5928-L5935 I believe typolink() takes care of that already by adding proper id when making cHash. If you also look to menuTypoLink() in AbstractMenuContentObject.php, you will see that it supplies id. I believe that this change is not ok.AbstractMenuContentObject.php:671ReplyI have a case for that. We had a project when we had to send the user to a fixed page for two languages of four. -
Ludovic Nogueira commented on patch set 4 09/30/16, 12:08
> (1 comment) > > I do not think this is needed. See here: https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php#L5928-L5935 > > I believe typolink() takes care of that already by adding proper > id when making cHash. If you also look to menuTypoLink() in > AbstractMenuContentObject.php, you will see that it supplies id. > > I believe that this change is not ok. That's true. At least for both website that caused us the problem. We just deleted addQueryString.exclude and it work just fine now. (at least with realurl 2.1.4 and typo3 6.2.27) -
Ludovic Nogueira voted on patch set 4 CR -1 09/30/16, 12:09
-
Dmitry Dulepov commented on patch set 4 09/30/16, 12:14
The place, which actually should be changed is near the function named analyzeCacheHashRequirements(). -
Dmitry Dulepov uploaded patch set 5 09/30/16, 12:25
-
Dmitry Dulepov commented on patch set 5 09/30/16, 12:26
I changed it in the place where the id should be set. This way it will not have side effects. -
TYPO3com voted on patch set 5 V +1 09/30/16, 12:28 Completed build in 03m 21s on Fri, 30 Sep, 02:28 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3301
-
Stephan Großberndt voted on patch set 5 CR +1 09/30/16, 15:09
-
Andreas Bouche commented on patch set 5 CR +1 V +1 09/30/16, 15:27
Works for me. -
Michael Oehlhof voted on patch set 5 CR +1 09/30/16, 19:06
-
Frederic Gaus voted on patch set 5 CR +1 V +1 10/06/16, 14:06
-
anonymized-54557 commented on patch set 5 CR +1 V +1 10/06/16, 15:37
Works for me in 6.2.27 -
Xavier Perseguers voted on patch set 5 CR +1 V +1 10/10/16, 09:07
-
Daniel Goerz commented on patch set 5 CR -1 10/11/16, 09:04
AbstractMenuContentObject.php:1174$this-getTypoScriptFrontendController() -
Stephan Großberndt commented on patch set 6 10/11/16, 09:43
Published edit on patch set 5. -
Stephan Großberndt commented on patch set 6 CR +1 10/11/16, 09:44
I really hate to throw away all those review- and verify-votes :-( This is no change in behaviour. -
Frederic Gaus voted on patch set 6 CR +1 V +1 10/11/16, 09:44
-
TYPO3com voted on patch set 6 V +1 10/11/16, 09:48 Completed build in 04m 37s on Tue, 11 Oct, 11:48 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3616
-
anonymized-54557 commented on patch set 6 10/11/16, 11:06
Fails for me in 6.2.27 on a page where the initial Version worked (directly accessing $GLOBALS['TSFE']) Fatal error: Call to undefined method TYPO3\CMS\Frontend\ContentObject\Menu\TextMenuContentObject::getTypoScriptFrontendController() Checked the code but couldn't find a method with this name in 6.2.27. Since i could only check 6.2 and not 7.6/master i'm unsure how to verify. I think we need this method getTypoScriptFrontendController() returning tsfe added to 6.2 in this abstract class. -
Wouter Wolters commented on patch set 6 10/11/16, 11:07
Maik: In 6.2 we will be using the $GLOBALS instead of the getter function. For 7.6 and master we can use the getter. -
Stephan Großberndt commented on patch set 6 10/11/16, 11:08
Since this is the patch for master (where getTypoScriptFrontendController exists) this should be used here. Verify is needed for master/7.6 once this is in, the backport for 6.2 may either introduce a getTypoScriptFrontendController method there or simply use GLOBALS['TSFE']. to verify on 6.2 now copy the getTypoScriptFrontendController method -
Xavier Perseguers voted on patch set 6 CR +1 V +1 10/11/16, 11:30
-
Michael Oehlhof voted on patch set 6 CR +1 10/11/16, 13:56
-
anonymized-54557 voted on patch set 6 CR +1 10/11/16, 14:45
-
Andreas Bouche voted on patch set 6 CR +1 V +1 10/12/16, 13:54
-
Andreas Kienast voted on patch set 6 CR +1 10/12/16, 20:28
-
Xavier Perseguers voted on patch set 6 CR +2 V +2 10/13/16, 07:50
-
Gerrit merged patch set 6 10/13/16, 07:51