Review main Merged

49946[TASK] Make use of edit icons consistent

Daniel Windloff CR +2 V +2 Normal +43 −32 updated 10/08/16, 13:05

Commit message

Use the following icons to indicate different kinds of "edit actions":
* actions-open: single edit action
* actions-document-open: multi edit action
* actions-page-open: edit page properties

Review

  • Code review CR +2
    • Jan Helke +2
    • Frank Nägler +1
  • Verified V +2
    • Jan Helke +2
    • Tomasz Stępniak +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 1418

  1. Daniel Windloff uploaded patch set 1 09/15/16, 14:18

  2. TYPO3com voted on patch set 1 V +1 09/15/16, 14:22 Completed build in 03m 20s on Thu, 15 Sep, 04:22 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3088

  3. Daniel Windloff uploaded patch set 2 09/16/16, 08:38

  4. TYPO3com voted on patch set 2 V +1 09/16/16, 08:42 Completed build in 03m 34s on Fri, 16 Sep, 10:42 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3097

  5. Markus Sommer commented on patch set 2 CR +1 V +1 09/16/16, 09:51

    Uff its really tricky to review this patch but all looks fine :)
  6. Daniel Windloff commented on patch set 2 09/16/16, 10:42

    Thx. For me, some icons are hard to find... I have created a pull request with my assumptions for that change: https://github.com/wmdbsystems/T3.Icons/pull/276/files
  7. Tymoteusz Motylewski commented on patch set 2 09/16/16, 19:43

    let's make the title more verbose. Like "Consistent usage of edit icons in BE"
  8. Daniel Windloff updated the commit message in patch set 3 09/17/16, 06:08

  9. TYPO3com voted on patch set 3 V +1 09/17/16, 06:12 Completed build in 03m 33s on Sat, 17 Sep, 08:12 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3112

  10. Daniel Windloff uploaded patch set 4 10/07/16, 13:16

  11. TYPO3com voted on patch set 4 V +1 10/07/16, 13:19 Completed build in 03m 35s on Fri, 7 Oct, 03:19 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3377

  12. Frank Nägler commented on patch set 4 CR -1 10/07/16, 13:51

    Thy for your patch, but please fix the PSR-2 issues, spaces instead of tabs. The TYPO3 core use PSR-2 standard. We have a .editorconfig file which should configure your IDE, the most IDEs have a plugin or support this files directly.

    ElementInformationController.php:596

    no tabs please, we use PSR-2

    ElementInformationController.php:605

    here too

    ElementInformationController.php:613

    please fix for the complete file.

    InlineRecordContainer.php:495

    spaces instead of tabs
  13. Frank Nägler commented on patch set 4 CR 0 10/07/16, 13:52

    sry, my mistake. for the markup in the string it is okay to have tabs.
  14. Frank Nägler commented on patch set 4 CR +1 10/07/16, 13:55

    ElementInformationController.php:596 Reply

    ignore my comment

    ElementInformationController.php:605 Reply

    ignore my comment

    ElementInformationController.php:613 Reply

    ignore my comment

    InlineRecordContainer.php:495 Reply

    ignore my comment
  15. Frank Nägler voted on patch set 4 V +1 10/07/16, 14:10

  16. Tomasz Stępniak voted on patch set 4 V +1 10/08/16, 10:31

  17. Jan Helke voted on patch set 4 CR +2 V +2 10/08/16, 13:05

  18. Gerrit merged patch set 4 10/08/16, 13:05