49946[TASK] Make use of edit icons consistent
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Frank Nägler +1
-
Verified V +2
- Jan Helke +2
- Tomasz Stępniak +1
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 19
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php+5 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php6+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php2+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+11 −11
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/IndexListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html+1 −1
- typo3/sysext/core/Classes/Database/QueryView.php+1 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/Distribution/Show.html+1 −1
- typo3/sysext/frontend/Classes/Controller/TranslationStatusController.php+2 −2
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+3 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −1
- typo3/sysext/sys_note/Resources/Private/Templates/Note/List.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/InformationModule.html+1 −1
- typo3/sysext/version/Classes/Controller/VersionModuleController.php+8 −4
Review log 1418
-
Daniel Windloff uploaded patch set 1 09/15/16, 14:18
-
TYPO3com voted on patch set 1 V +1 09/15/16, 14:22 Completed build in 03m 20s on Thu, 15 Sep, 04:22 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3088
-
Daniel Windloff uploaded patch set 2 09/16/16, 08:38
-
TYPO3com voted on patch set 2 V +1 09/16/16, 08:42 Completed build in 03m 34s on Fri, 16 Sep, 10:42 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3097
-
Markus Sommer commented on patch set 2 CR +1 V +1 09/16/16, 09:51
Uff its really tricky to review this patch but all looks fine :) -
Daniel Windloff commented on patch set 2 09/16/16, 10:42
Thx. For me, some icons are hard to find... I have created a pull request with my assumptions for that change: https://github.com/wmdbsystems/T3.Icons/pull/276/files -
Tymoteusz Motylewski commented on patch set 2 09/16/16, 19:43
let's make the title more verbose. Like "Consistent usage of edit icons in BE" -
Daniel Windloff updated the commit message in patch set 3 09/17/16, 06:08
-
TYPO3com voted on patch set 3 V +1 09/17/16, 06:12 Completed build in 03m 33s on Sat, 17 Sep, 08:12 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3112
-
Daniel Windloff uploaded patch set 4 10/07/16, 13:16
-
TYPO3com voted on patch set 4 V +1 10/07/16, 13:19 Completed build in 03m 35s on Fri, 7 Oct, 03:19 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3377
-
Frank Nägler commented on patch set 4 CR -1 10/07/16, 13:51
Thy for your patch, but please fix the PSR-2 issues, spaces instead of tabs. The TYPO3 core use PSR-2 standard. We have a .editorconfig file which should configure your IDE, the most IDEs have a plugin or support this files directly.ElementInformationController.php:596no tabs please, we use PSR-2ElementInformationController.php:605here tooElementInformationController.php:613please fix for the complete file.InlineRecordContainer.php:495spaces instead of tabs -
Frank Nägler commented on patch set 4 CR 0 10/07/16, 13:52
sry, my mistake. for the markup in the string it is okay to have tabs. -
Frank Nägler commented on patch set 4 CR +1 10/07/16, 13:55
ElementInformationController.php:596Replyignore my commentElementInformationController.php:605Replyignore my commentElementInformationController.php:613Replyignore my commentInlineRecordContainer.php:495Replyignore my comment -
Frank Nägler voted on patch set 4 V +1 10/07/16, 14:10
-
Tomasz Stępniak voted on patch set 4 V +1 10/08/16, 10:31
-
Jan Helke voted on patch set 4 CR +2 V +2 10/08/16, 13:05
-
Gerrit merged patch set 4 10/08/16, 13:05