49949[BUGFIX] Avoid duplicated classes in typolink VH
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jigal van Hemert +1
-
Verified V +2
- Markus Klein +2
- Jigal van Hemert +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1722
-
Georg Ringer uploaded patch set 1 09/16/16, 06:19
-
TYPO3com voted on patch set 1 V -1 09/16/16, 06:23 Completed build in 03m 46s on Fri, 16 Sep, 08:23 AM Test Summary: 4 of 18511 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3095
-
Georg Ringer uploaded patch set 2 09/16/16, 07:05
-
TYPO3com voted on patch set 2 V +1 09/16/16, 07:09 Completed build in 03m 41s on Fri, 16 Sep, 09:09 AM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3096
-
Oliver Hader commented on patch set 2 CR -1 09/16/16, 13:14
Don't merge... (bootup day) -
Markus Klein voted on patch set 2 CR +1 09/20/16, 12:11
-
Oliver Hader voted on patch set 2 CR 0 09/20/16, 12:56
-
Tymoteusz Motylewski commented on patch set 2 CR -1 09/20/16, 15:37
I will push a followup with unit test -
Tymoteusz Motylewski uploaded patch set 3 09/20/16, 15:41
-
TYPO3com voted on patch set 3 V +1 09/20/16, 15:45 Completed build in 03m 36s on Tue, 20 Sep, 05:45 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3151
-
Markus Klein voted on patch set 3 CR +1 V +1 09/20/16, 15:45
-
Jigal van Hemert commented on patch set 3 09/20/16, 19:49
TypolinkViewHelper.php:165What about implode(' ', array_unique(explode(' ', trim($typolinkConfiguration['class']) . ' ' . trim($class)))); ? It saves one explode and one array_merge in exchange of two trims and a concatenate. Aren't string operations faster than array functions? -
Markus Klein commented on patch set 3 CR 0 V 0 09/20/16, 20:12
TypolinkViewHelper.php:165ReplyGood idea. I would add an array_filter to kick possible empty values. -
Markus Klein commented on patch set 4 09/20/16, 20:13
Published edit on patch set 3. -
Markus Klein commented on patch set 5 09/20/16, 20:14
Published edit on patch set 4. -
TYPO3com voted on patch set 4 V -1 09/20/16, 20:17 Completed build in 03m 36s on Tue, 20 Sep, 10:17 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3158
-
TYPO3com voted on patch set 5 V +1 09/20/16, 20:17 Completed build in 02m 35s on Tue, 20 Sep, 10:17 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3159
-
Markus Klein voted on patch set 5 CR +1 V +1 09/20/16, 20:17
-
Jigal van Hemert commented on patch set 5 CR +1 V +1 09/21/16, 06:58
Although I couldn't find any technical need to have unique class names it's indeed cleaner to avoid them. -
Markus Klein voted on patch set 5 CR +2 V +2 09/21/16, 08:40
-
Gerrit merged patch set 5 09/21/16, 08:40
-
Markus Klein commented on patch set 6 09/21/16, 08:40
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 0bd59464d2a4b979657576f39eb748e1ba070be4