Review main Merged

49952[TASK] Fluidification of SortPages Wizard

Michael Oehlhof CR +2 V +2 Normal +126 −62 updated 10/06/16, 09:45

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Wouter Wolters +1
  • Verified V +2
    • Jan Helke +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Michael Oehlhof uploaded patch set 1 09/16/16, 11:06

  2. Michael Oehlhof commented on patch set 1 V -1 09/16/16, 11:07

    49939 has to get merged before this.
  3. TYPO3com voted on patch set 1 V +1 09/16/16, 11:10 Completed build in 03m 32s on Fri, 16 Sep, 01:10 PM Test Summary: 18511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3098

  4. Michael Oehlhof uploaded patch set 2 09/19/16, 08:02

  5. TYPO3com voted on patch set 2 V +1 09/19/16, 08:05 Completed build in 03m 14s on Mon, 19 Sep, 10:05 AM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3125

  6. Robert van Kammen voted on patch set 2 CR +1 V +1 09/28/16, 14:00

  7. Markus Sommer commented on patch set 2 CR +1 V +1 09/30/16, 08:46

    Works fine All backend sort functions work. I have clicked all :)
  8. Georg Ringer commented on patch set 2 09/30/16, 08:49

    SortPagesWizard.html:3

    imo not needed anymore

    SortPagesWizard.html:23

    there is a class for that

    SortPagesWizard.html:46

    just use cshItem -> f:format.raw()
  9. Wouter Wolters commented on patch set 2 09/30/16, 08:51

    SortPagesWizard.html:23 Reply

    class="text-nowrap"
  10. Wouter Wolters uploaded patch set 3 09/30/16, 08:59

  11. Wouter Wolters uploaded patch set 4 09/30/16, 09:00

  12. Wouter Wolters voted on patch set 4 CR +1 V +1 09/30/16, 09:00

  13. TYPO3com voted on patch set 3 V +1 09/30/16, 09:03 Completed build in 03m 26s on Fri, 30 Sep, 11:03 AM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3290

  14. TYPO3com voted on patch set 4 V +1 09/30/16, 09:04 Completed build in 03m 48s on Fri, 30 Sep, 11:04 AM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3291

  15. Jan Helke voted on patch set 4 CR +2 V +2 10/06/16, 09:45

  16. Gerrit merged patch set 4 10/06/16, 09:45