49964[BUGFIX] Change dbClientCompress setting
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1012
-
Richard Haeser uploaded patch set 1 09/18/16, 12:03
-
Richard Haeser commented on patch set 1 09/18/16, 12:04
Should I add a rst-file for the change? In sysext/core/Documentation/Changelog/8.1/Breaking-75454-LocalConfigurationDBConfigStructureHasChanged.rst there is a wrong path now. -
TYPO3com voted on patch set 1 V -1 09/18/16, 12:06 Completed build in 03m 08s on Sun, 18 Sep, 02:06 PM Test Summary: 36 of 18529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3117
-
Richard Haeser uploaded patch set 2 09/18/16, 12:11
-
TYPO3com voted on patch set 2 V +1 09/18/16, 12:15 Completed build in 03m 25s on Sun, 18 Sep, 02:15 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3118
-
Wouter Wolters commented on patch set 2 09/22/16, 20:22
DefaultConfiguration.php:77why do you remove the default value here? -
Richard Haeser commented on patch set 2 09/26/16, 20:02
DefaultConfiguration.php:77ReplyBecause this options doesn't belong there anymore. If you want them in the default configuration it should be in DB/Connections/Default. But if you do, the unit-tests do fail because a database connection is initiated. -
Wouter Wolters voted on patch set 2 CR +1 09/30/16, 09:22
-
Dmitry Dulepov commented on patch set 2 CR -1 09/30/16, 11:01
I do not like the change because it makes 'dbClientCompress' option confusing. Option name sounds like a boolean but all checks are done by bit-anding with MYSQLI_CLIENT_COMPRESS, which equals 32. 'driverOptions' is ok to compare to MYSQLI_CLIENT_COMPRESS because options do not sound like boolean. Also it appears like the option can only contain MYSQLI_CLIENT_COMPRESS. What's the point of using this value instead of boolean? I do not think this is a good change. More, all options should be in the DefaultConfiguration.php. You should be able to work with options without executing update wizards. This is why we have DefaultConfiguration.php with all those options. -
Richard Haeser commented on patch set 2 09/30/16, 11:21
The change to driverOption was already in CMS8 but by setting the compress option in install tool now breaks the system (try a clean cms8, set compress to true in install tool, and revisit the install tool). This is because a (in my opinion) wrongly excecuted update of the variable. I think you are right with the opinion the option should be available in the install tool but setting it on the location where it should be, makes functional test go wrong because it initiates a database connection. ( see failing build ) if you have a solution for that, please show me. So what I did was just revertiving the change to the old functionality and only repositioned the setting in the configuration according the other options. > I do not like the change because it makes 'dbClientCompress' option > confusing. Option name sounds like a boolean but all checks are > done by bit-anding with MYSQLI_CLIENT_COMPRESS, which equals 32. > 'driverOptions' is ok to compare to MYSQLI_CLIENT_COMPRESS because > options do not sound like boolean. > > Also it appears like the option can only contain MYSQLI_CLIENT_COMPRESS. > What's the point of using this value instead of boolean? > > I do not think this is a good change. More, all options should be > in the DefaultConfiguration.php. You should be able to work with > options without executing update wizards. This is why we have > DefaultConfiguration.php with all those options. -
Christian Kuhn commented on patch set 2 09/10/17, 08:09
this has been resolved with https://review.typo3.org/#/c/54077/ and the removal of typo3_db in master. will abandon. -
Christian Kuhn abandoned the change 09/10/17, 08:10