49968[!!!][TASK] Deprecate usage of record rendering in page module
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Michael Oehlhof +1
-
Verified V +2
- Wouter Wolters +2
- Michael Oehlhof +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php1+7 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+0 −16
- typo3/sysext/core/Documentation/Changelog/master/Breaking-77987-RemovalFe_usersRenderingInPageModule.rstnew+33 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-77987-DeprecatedRecordListingInPageModule.rstnew+22 −0
Review log 1013
-
Georg Ringer uploaded patch set 1 09/18/16, 19:36
-
TYPO3com voted on patch set 1 V +1 09/18/16, 19:39 Completed build in 03m 13s on Sun, 18 Sep, 09:39 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3121
-
Claus Due voted on patch set 1 CR +1 09/19/16, 08:19
-
Markus Klein commented on patch set 2 09/20/16, 12:41
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 09/20/16, 12:45 Completed build in 04m 29s on Tue, 20 Sep, 02:45 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3146
-
Michael Oehlhof voted on patch set 2 CR +1 09/20/16, 12:58
-
Oliver Klee commented on patch set 2 CR -1 09/22/16, 11:24
PageLayoutController.php:386This field is initialized as an array by default, i.e., the deprecation message will always be there. I propose to use !empty instead. -
Georg Ringer uploaded patch set 3 09/22/16, 11:50
-
TYPO3com voted on patch set 3 V +1 09/22/16, 11:54 Completed build in 03m 39s on Thu, 22 Sep, 01:54 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3182
-
Wouter Wolters voted on patch set 3 CR +1 V +1 09/30/16, 08:17
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 09/30/16, 19:41
-
Wouter Wolters voted on patch set 3 CR +2 V +2 10/06/16, 09:57
-
Gerrit merged patch set 3 10/06/16, 09:57