Review main Merged Breaking

49968[!!!][TASK] Deprecate usage of record rendering in page module

Georg Ringer CR +2 V +2 Normal +62 −16 updated 10/06/16, 09:57

Commit message

To follow the concept of apps and avoiding code duplications and
confusion of users, the rendering of records in the page module
is deprecated.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
  • Verified V +2
    • Wouter Wolters +2
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1013

  1. Georg Ringer uploaded patch set 1 09/18/16, 19:36

  2. TYPO3com voted on patch set 1 V +1 09/18/16, 19:39 Completed build in 03m 13s on Sun, 18 Sep, 09:39 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3121

  3. Claus Due voted on patch set 1 CR +1 09/19/16, 08:19

  4. Markus Klein commented on patch set 2 09/20/16, 12:41

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 09/20/16, 12:45 Completed build in 04m 29s on Tue, 20 Sep, 02:45 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3146

  6. Michael Oehlhof voted on patch set 2 CR +1 09/20/16, 12:58

  7. Oliver Klee commented on patch set 2 CR -1 09/22/16, 11:24

    PageLayoutController.php:386

    This field is initialized as an array by default, i.e., the deprecation message will always be there. I propose to use !empty instead.
  8. Georg Ringer uploaded patch set 3 09/22/16, 11:50

  9. TYPO3com voted on patch set 3 V +1 09/22/16, 11:54 Completed build in 03m 39s on Thu, 22 Sep, 01:54 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3182

  10. Wouter Wolters voted on patch set 3 CR +1 V +1 09/30/16, 08:17

  11. Michael Oehlhof voted on patch set 3 CR +1 V +1 09/30/16, 19:41

  12. Wouter Wolters voted on patch set 3 CR +2 V +2 10/06/16, 09:57

  13. Gerrit merged patch set 3 10/06/16, 09:57