Review main Merged

49969[BUGFIX] PSR-7 properties must be initialized as array

Patrik Karisch CR +2 V +2 Easy +5 −5 updated 09/19/16, 09:57

Commit message

All the PSR-7 ServerRequest properties must be initialized as arrays, as
they can be accessed through getters without be correctly initialized
from the outside application. This can result in type errors.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Patrik Karisch uploaded patch set 1 09/19/16, 02:03

  2. TYPO3com voted on patch set 1 V +1 09/19/16, 02:07 Completed build in 03m 22s on Mon, 19 Sep, 04:07 AM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3122

  3. Benni Mack updated the commit message in patch set 2 09/19/16, 04:24

  4. Benni Mack voted on patch set 2 CR +1 V +1 09/19/16, 04:25

  5. TYPO3com voted on patch set 2 V +1 09/19/16, 04:28 Completed build in 03m 52s on Mon, 19 Sep, 06:28 AM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3123

  6. Stefan Neufeind voted on patch set 2 CR +1 V +1 09/19/16, 07:55

  7. Georg Ringer voted on patch set 2 CR +2 V +2 09/19/16, 09:57

  8. Gerrit merged patch set 2 09/19/16, 09:57

  9. Georg Ringer commented on patch set 3 09/19/16, 09:57

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 96b785e0371ea280bf4c8e45ca4248bb895273f9