Review TYPO3_7-6 Abandoned

49978[BUGFIX] Do not turn storages automatically offline

Sascha Egerer CR 0 V 0 Normal +29 −42 updated 10/12/16, 10:35

Commit message

Storages should not be taken offline automatically.
Currently the storage turns offline if a configuration error is
detected.
But depending on the driver a configuration error can be a temporary
problem that just exists for seconds (like local filemount is
not available).

A storage should only be turned offline if you are in the backend
context
and the initialization fails.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 89

  1. Sascha Egerer uploaded patch set 1 09/20/16, 07:19

  2. TYPO3com voted on patch set 1 V +1 09/20/16, 07:22 Completed build in 03m 12s on Tue, 20 Sep, 09:22 AM Test Summary: 34906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-117

  3. Martin Fox voted on patch set 1 CR -1 V -1 10/06/16, 15:55

  4. Sascha Egerer commented on patch set 1 10/06/16, 16:20

    @Martin What's your problem with the patch? Does it not work? It's already merged in master.
  5. Martin Fox commented on patch set 1 10/07/16, 08:35

    When changing the folder name, does not work.
  6. Wouter Wolters commented on patch set 1 10/07/16, 08:42

    Frans his reply to this in the master patch was: That is correct. When storage is unavailable and your logged in into the back end the storage is marked offline So that it does not work is correct when changing foldername
  7. Helmut Hummel commented on patch set 1 CR -2 10/11/16, 12:04

    I'm having issues with master currently, so I'm against backporting this until the issues are resolved in master
  8. Helmut Hummel commented on patch set 1 10/12/16, 10:24

    ResourceStorage.php:412

    removing the public method cannot be done in 7.6
  9. Helmut Hummel abandoned the change 10/12/16, 10:35

    This imho needs a complete re-tought