Review main Merged

49979[BUGFIX] Use correct dependency in EXT:compatibility7

Georg Ringer CR +2 V +2 Easy +1 −1 updated 09/20/16, 13:22

Commit message

To avoid occasional errors in the Extension Manager
the version must be added as well.

Review

  • Code review CR +2
    • Markus Klein +2
    • Claus Due +1
    • Helmut Hummel +1
    • Philipp Gampe +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1112

  1. Georg Ringer uploaded patch set 1 09/20/16, 11:24

  2. TYPO3com voted on patch set 1 V +1 09/20/16, 11:28 Completed build in 03m 30s on Tue, 20 Sep, 01:28 PM Test Summary: 18529 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3141

  3. Philipp Gampe voted on patch set 1 CR +1 09/20/16, 11:48

  4. Helmut Hummel commented on patch set 1 CR +1 V +1 09/20/16, 11:55

    It does not make much sense to me that "compatiblity7" *depends" on indexed_search. But IIRC, the ext is planned to be renamed to legacy_search or something. Then it might make sense. Anyway, this fix is valid :)
  5. Markus Klein commented on patch set 1 09/20/16, 12:04

    Why does it depend on indexed_search at all??
  6. Markus Klein commented on patch set 1 09/20/16, 12:05

    If it is only about loading order, it should be listed under "suggested".
  7. Claus Due commented on patch set 1 CR +1 09/20/16, 12:46

    This should be merged. If someone then feels like following it up with a commit that moves this dependency to a suggestion that's perfect - but this merge request solves a very real bug!
  8. Markus Klein commented on patch set 1 CR -1 09/20/16, 12:51

    Sorry Claus, requiring an extension that isn't necessary is IMO a real bug as well. -1 until this is clarified.
  9. Helmut Hummel commented on patch set 1 09/20/16, 13:04

    I tend to agree with Claus here. The code itself depends on code in indexed_search (uses classes), so it cannot just be turned into a suggestion. Without indexed_search installed this would be useless. As said, this ext should then be renamed to legacy_indexed_search_plugin or something along that way, because forcing compatibility7 to also require specific core extension would be bad. Nevertheless, this can and should be a different task
  10. Markus Klein commented on patch set 1 CR +1 V +1 09/20/16, 13:21

    > code itself depends on code in indexed_search This answers my question. Perfectly fine then.
  11. Markus Klein voted on patch set 1 CR +2 V +2 09/20/16, 13:21

  12. Gerrit merged patch set 1 09/20/16, 13:22