Review main Merged

50002[TASK] Fluidification of TaskCenter

Michael Oehlhof CR +2 V +2 Normal +161 −76 updated 10/06/16, 16:19

Commit message

Review

  • Code review CR +2
    • Jan Helke +2
    • Markus Sommer +1
    • Jörg Bösche +1
  • Verified V +2
    • Jan Helke +2
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 911

  1. Michael Oehlhof uploaded patch set 1 09/21/16, 14:43

  2. TYPO3com voted on patch set 1 V +1 09/21/16, 14:48 Completed build in 04m 48s on Wed, 21 Sep, 04:48 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3167

  3. Jörg Bösche voted on patch set 1 CR +1 09/26/16, 19:11

  4. Markus Sommer commented on patch set 1 09/30/16, 12:04

    At the moment only tag based fluid is used for tags not for format see typo3/sysext/install/Resources/Private/Partials/Action/Common/StatusMessage.html:26 or typo3/sysext/backend/Resources/Private/Templates/NewContentElement/MenuItem.html:9

    Description.html:1

    Why do not you use {description -> f:format.nl2br()}

    Description.html:4

    Why do not you use {description -> f:format.nl2br()}

    ListMenu.html:36

    Why do not you use {item.icon -> f:format.raw()}

    ListMenu.html:52

    Why do not you use {… -> f:format.raw()}

    ListMenu.html:56

    Why do not you use {… -> f:format.raw()}

    ModuleContent.html:7

    Why do not you use {… -> f:format.raw()}

    ModuleContent.html:14

    Why do not you use {… -> f:format.raw()}
  5. Michael Oehlhof commented on patch set 1 09/30/16, 13:06

    ListMenu.html:56 Reply

    you mean f:format.nl2br here
  6. Michael Oehlhof uploaded patch set 2 09/30/16, 13:07

  7. TYPO3com voted on patch set 2 V +1 09/30/16, 13:11 Completed build in 03m 11s on Fri, 30 Sep, 03:11 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3302

  8. Markus Sommer commented on patch set 2 CR +1 V +1 09/30/16, 13:27

    Perfect :)
  9. Jörg Bösche voted on patch set 2 CR +1 10/06/16, 10:06

  10. Jan Helke voted on patch set 2 CR +2 V +2 10/06/16, 16:19

  11. Gerrit merged patch set 2 10/06/16, 16:19