Review main Merged

50011[BUGFIX] Remove field restriction in PageLinkHandler

Georg Ringer CR +2 V +2 Easy +1 −1 updated 09/25/16, 21:50

Commit message

The full row must be provided as it is used later on in the
BackendUtility::getRecordTitle(). Removing fields leads to missing fields
in the title.

Review

  • Code review CR +2
    • Markus Klein +2
    • Cristian Buja +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Cristian Buja +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 09/23/16, 09:01

  2. TYPO3com voted on patch set 1 V +1 09/23/16, 09:05 Completed build in 03m 48s on Fri, 23 Sep, 11:05 AM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3192

  3. Markus Klein voted on patch set 1 CR +1 V +1 09/23/16, 09:57

  4. Wouter Wolters voted on patch set 1 CR +1 09/23/16, 10:20

  5. Tymoteusz Motylewski commented on patch set 1 V +1 09/24/16, 09:37

    works. however, I'm wondering whether the performance impact is sth we should consider (incl. memory footprint) when you have many CE's and many additional columns in CE. Maybe we can just add columns defined in label_alt to the select? I don't have strong opinion on that.
  6. Cristian Buja voted on patch set 1 CR +1 V +1 09/24/16, 11:00

  7. Markus Klein commented on patch set 1 CR +2 V +2 09/25/16, 21:50

    @Tymek: Nope that is not enough. getRecordTitle can involve also userfuncs which rely on the full row actually. The same approach is taken in the list module as well.
  8. Gerrit merged patch set 1 09/25/16, 21:50