50031[BUGFIX] Add missing functionality for YouTube "related" parameter
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
- Frank Nägler +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3852
Show 1827 earlier messages
-
TYPO3com uploaded patch set 1 09/27/16, 13:05
-
Susi Moog updated the commit message in patch set 2 09/27/16, 13:08
-
TYPO3com voted on patch set 1 V -1 09/27/16, 13:09 Completed build in 03m 44s on Tue, 27 Sep, 03:09 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3225
-
TYPO3com voted on patch set 2 V -1 09/27/16, 13:12 Completed build in 03m 37s on Tue, 27 Sep, 03:12 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3226
-
Sebastian Michaelsen commented on patch set 2 CR -1 09/27/16, 14:01
rel is short for "related" not "relative" -
Andreas Kienast commented on patch set 3 09/27/16, 14:55
Published edit on patch set 2. -
Andreas Kienast commented on patch set 4 09/27/16, 14:55
Published edit on patch set 3. -
TYPO3com voted on patch set 3 V +1 09/27/16, 14:58 Completed build in 03m 36s on Tue, 27 Sep, 04:58 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3227
-
TYPO3com voted on patch set 4 V +1 09/27/16, 15:00 Completed build in 04m 27s on Tue, 27 Sep, 05:00 PM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3228
-
Georg Ringer voted on patch set 4 CR +1 V +1 09/28/16, 06:33
-
Wouter Wolters uploaded patch set 5 09/30/16, 08:36
-
Wouter Wolters uploaded patch set 6 09/30/16, 08:37
-
TYPO3com voted on patch set 5 V -1 09/30/16, 08:40 Completed build in 03m 22s on Fri, 30 Sep, 10:40 AM Test Summary: 18537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3286
-
TYPO3com voted on patch set 6 V -1 09/30/16, 08:40 Completed build in 02m 58s on Fri, 30 Sep, 10:40 AM Test Summary: 18537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3287
-
Wouter Wolters uploaded patch set 7 09/30/16, 08:44
-
TYPO3com voted on patch set 7 V +1 09/30/16, 08:47 Completed build in 03m 08s on Fri, 30 Sep, 10:47 AM Test Summary: 18537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3289
-
Wouter Wolters voted on patch set 7 CR +1 V +1 09/30/16, 08:48
-
Andreas Wolf commented on patch set 7 CR -1 10/04/16, 20:27
This is a feature and should have a feature RST file. -
Wouter Wolters commented on patch set 7 10/04/16, 20:30
No this is a task and should go into 7.6 as well. This is a missing piece that should have been implemented already. -
Wouter Wolters commented on patch set 7 10/04/16, 20:31
See also the reaction of Frans, the author of this code, in Forge. -
Frans Saris commented on patch set 7 10/15/16, 04:44
This should indeed go into 7.6 imo its more a bug then a task so to say -
Benni Mack commented on patch set 7 10/17/16, 12:27
Tim, I'd recommend you use a real email address. If "noreply@example.com" is actually your real email address, you got my respect but also my sorries for all the spam coming to you ;) -
Wouter Wolters updated the commit message in patch set 8 10/18/16, 14:17
-
Wouter Wolters voted on patch set 8 CR +1 V +1 10/18/16, 14:18
-
TYPO3com voted on patch set 8 V -1 10/18/16, 14:23 Completed build in 05m 18s on Tue, 18 Oct, 04:23 PM Test Summary: 2 of 19569 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3894
-
Wouter Wolters rebased onto patch set 9 10/18/16, 14:29
-
Wouter Wolters commented on patch set 10 10/18/16, 14:29
Published edit on patch set 9.
-
TYPO3com voted on patch set 9 V -1 10/18/16, 14:35 Completed build in 05m 52s on Tue, 18 Oct, 04:35 PM Test Summary: 2 of 19507 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3897
-
TYPO3com voted on patch set 10 V -1 10/18/16, 14:36 Completed build in 07m 27s on Tue, 18 Oct, 04:36 PM Test Summary: 2 of 19507 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3898
-
Andreas Allacher commented on patch set 10 10/19/16, 12:21
YouTubeRendererTest.php:172Probably known due to bamboo anyway but this "/" isn't in the URL above. -
Wouter Wolters commented on patch set 11 10/19/16, 12:22
Published edit on patch set 10. -
TYPO3com voted on patch set 11 V +1 10/19/16, 12:27 Completed build in 04m 37s on Wed, 19 Oct, 02:27 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3925
-
Wouter Wolters voted on patch set 11 CR +1 V +1 10/19/16, 12:28
-
Andreas Allacher voted on patch set 11 CR +1 10/19/16, 12:50
-
Josef Glatz voted on patch set 11 CR +1 10/20/16, 04:04
-
Frans Saris voted on patch set 11 CR +1 V +1 10/20/16, 19:20
-
Josef Glatz voted on patch set 11 V +1 10/21/16, 03:52
-
Markus Klein commented on patch set 11 CR -1 10/21/16, 06:08
YouTubeRenderer.php:118an isset() check is missing here -
Markus Klein commented on patch set 12 10/21/16, 06:10
Published edit on patch set 11. -
Markus Klein commented on patch set 12 10/21/16, 06:11
IMO we have to implement all options the youtube API supports here. -
Markus Klein commented on patch set 12 10/21/16, 06:13
-
TYPO3com voted on patch set 12 V -1 10/21/16, 06:14 Completed build in 03m 54s on Fri, 21 Oct, 08:14 AM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3961
-
Markus Klein commented on patch set 13 10/21/16, 06:21
Published edit on patch set 12. -
TYPO3com voted on patch set 13 V +1 10/21/16, 06:26 Completed build in 05m 02s on Fri, 21 Oct, 08:26 AM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3962
-
Andreas Allacher commented on patch set 13 10/21/16, 06:58
YouTubeRenderer.php:119Maybe we should make the check here the same way as for showinfo with (int)!empty(...) to do it the same way in the same method at least? -
Markus Klein commented on patch set 13 10/21/16, 08:19
YouTubeRenderer.php:119Replywell, the showinfo thingy is different because there is no protecting if clause that covers the not-set case. But I'm fine with either solution. -
Andreas Allacher commented on patch set 13 10/21/16, 10:22
YouTubeRenderer.php:119ReplyAh. True. I am also happy with both. It works this way so we can also keep it :) Anyone know what's faster :D -
Markus Klein voted on patch set 13 CR +1 V +1 10/21/16, 12:04
-
Frank Nägler voted on patch set 13 CR +1 10/21/16, 12:56
-
Christian Kuhn voted on patch set 13 CR +2 V +2 10/21/16, 13:37
-
Gerrit merged patch set 13 10/21/16, 13:37
-
Christian Kuhn commented on patch set 14 10/21/16, 13:37
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit a3f2234c880e8dd31281d2de34d38c9059ad9972