50035[BUGFIX] Fix evaluation of rootLevel configuration in NewRecordController
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Robert van Kammen +1
-
Verified V +2
- Wouter Wolters +2
- Robert van Kammen +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Georg Ringer uploaded patch set 1 09/28/16, 06:52
-
TYPO3com voted on patch set 1 V +1 09/28/16, 06:56 Completed build in 03m 37s on Wed, 28 Sep, 08:56 AM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3232
-
Wouter Wolters commented on patch set 1 09/28/16, 08:33
How can I reproduce this? The table sys_file_storage is not shown for me on other pages than pid=0 -
Markus Klein commented on patch set 1 09/28/16, 08:52
NewRecordController.php:506this is the xor again, I would keep that. -
Markus Klein commented on patch set 2 09/28/16, 08:54
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 09/28/16, 08:57 Completed build in 03m 24s on Wed, 28 Sep, 10:57 AM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3244
-
Markus Klein voted on patch set 2 CR +1 09/28/16, 09:03
-
Wouter Wolters voted on patch set 2 CR +1 V +1 09/28/16, 12:01
-
Robert van Kammen voted on patch set 2 CR +1 V +1 09/28/16, 12:45
-
Wouter Wolters voted on patch set 2 CR +2 V +2 09/28/16, 12:46
-
Gerrit merged patch set 2 09/28/16, 12:46
-
Wouter Wolters commented on patch set 3 09/28/16, 12:46
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f1dd477d7a11d1c877c2125cdd98da87f8236d66 -
Nicole Hummel commented on patch set 3 10/07/16, 07:22
Post -1. I will push an updateNewRecordController.php:499Now you consider every table where rootLevel is not set, can be inserted at root page - which is wrong!