50036[BUGFIX] Trim function name passed to GeneralUtility::callUserFunc()
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
- Wouter Wolters +1
- Eric Chavaillaz +1
- Andreas Kienast +1
- Nicole Hummel +1
-
Verified V +2
- Georg Ringer +2
- Nicole Hummel +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1618
-
Andreas Kienast uploaded patch set 1 09/28/16, 06:55
-
TYPO3com voted on patch set 1 V +1 09/28/16, 06:59 Completed build in 03m 38s on Wed, 28 Sep, 08:59 AM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3233
-
Georg Ringer voted on patch set 1 CR +1 V +1 09/28/16, 07:37
-
Oliver Klee voted on patch set 1 CR +1 09/28/16, 08:39
-
Wouter Wolters voted on patch set 1 CR +1 09/28/16, 08:43
-
Christian Kuhn commented on patch set 1 09/28/16, 14:01
is it possible to add a unit test for that case? maybe that's not too hard if we use a callback method (or a closure if possible?). -
Eric Chavaillaz voted on patch set 1 CR +1 V +1 09/28/16, 14:02
-
Nicole Hummel commented on patch set 1 CR -1 09/28/16, 16:39
Will add a test for that -
Nicole Hummel uploaded patch set 2 09/28/16, 16:42
-
Nicole Hummel voted on patch set 2 CR +1 V +1 09/28/16, 16:42
-
TYPO3com voted on patch set 2 V +1 09/28/16, 16:45 Completed build in 03m 04s on Wed, 28 Sep, 06:45 PM Test Summary: 18533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3263
-
Wouter Wolters voted on patch set 2 CR +1 09/28/16, 18:20
-
Andreas Kienast commented on patch set 2 CR +1 09/29/16, 03:21
Thanks for providing a test! -
Eric Chavaillaz voted on patch set 2 CR +1 09/29/16, 05:43
-
Oliver Klee voted on patch set 2 CR +1 09/29/16, 05:59
-
Georg Ringer voted on patch set 2 CR +2 V +2 09/29/16, 18:33
-
Gerrit merged patch set 2 09/29/16, 18:33
-
Georg Ringer commented on patch set 3 09/29/16, 18:33
Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit f656cd43d4da21d3bb99319b624f6ec8a6954668