Review main Merged

50061[TASK] Fluidification of installed services report

Michael Oehlhof CR +2 V +2 Hard +260 −107 updated 10/29/16, 11:44

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1115

  1. Michael Oehlhof uploaded patch set 1 09/28/16, 22:10

  2. TYPO3com voted on patch set 1 V +1 09/28/16, 22:14 Completed build in 03m 24s on Thu, 29 Sep, 12:14 AM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3268

  3. Jörg Bösche uploaded patch set 2 10/28/16, 23:16

  4. Jörg Bösche commented on patch set 2 CR +1 V +1 10/28/16, 23:18

    Restructured the code and added a simple unit test for the ServiceListReport class to check, if the method runs through the defined business logic.
  5. TYPO3com voted on patch set 2 V -1 10/28/16, 23:20 Completed build in 04m 05s on Sat, 29 Oct, 01:20 AM Test Summary: 19571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4391

  6. Jörg Bösche uploaded patch set 3 10/28/16, 23:38

  7. TYPO3com voted on patch set 3 V +1 10/28/16, 23:43 Completed build in 05m 09s on Sat, 29 Oct, 01:43 AM Test Summary: 19571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4393

  8. Jörg Bösche voted on patch set 3 CR +1 V +1 10/29/16, 00:00

  9. Christian Kuhn commented on patch set 3 10/29/16, 11:02

    ServicesListReportTest.php:51

    note: not strictly needed, parent::tearDown() from UnitTestCase will do that anyway.
  10. Christian Kuhn uploaded patch set 4 10/29/16, 11:04

  11. Christian Kuhn commented on patch set 4 CR +1 V +1 10/29/16, 11:06

    Please wait with a merge for a revote by Joerg.
  12. TYPO3com voted on patch set 4 V +1 10/29/16, 11:09 Completed build in 05m 14s on Sat, 29 Oct, 01:09 PM Test Summary: 19589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4405

  13. Jörg Bösche commented on patch set 4 CR +1 V +1 10/29/16, 11:09

    Thanks for the hints and the new patch set. Everything looks fine!
  14. Christian Kuhn voted on patch set 4 CR +2 V +2 10/29/16, 11:44

  15. Gerrit merged patch set 4 10/29/16, 11:44