50061[TASK] Fluidification of installed services report
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Jörg Bösche +1
-
Verified V +2
- Christian Kuhn +2
- Jörg Bösche +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1115
-
Michael Oehlhof uploaded patch set 1 09/28/16, 22:10
-
TYPO3com voted on patch set 1 V +1 09/28/16, 22:14 Completed build in 03m 24s on Thu, 29 Sep, 12:14 AM Test Summary: 18531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3268
-
Jörg Bösche uploaded patch set 2 10/28/16, 23:16
-
Jörg Bösche commented on patch set 2 CR +1 V +1 10/28/16, 23:18
Restructured the code and added a simple unit test for the ServiceListReport class to check, if the method runs through the defined business logic. -
TYPO3com voted on patch set 2 V -1 10/28/16, 23:20 Completed build in 04m 05s on Sat, 29 Oct, 01:20 AM Test Summary: 19571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4391
-
Jörg Bösche uploaded patch set 3 10/28/16, 23:38
-
TYPO3com voted on patch set 3 V +1 10/28/16, 23:43 Completed build in 05m 09s on Sat, 29 Oct, 01:43 AM Test Summary: 19571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4393
-
Jörg Bösche voted on patch set 3 CR +1 V +1 10/29/16, 00:00
-
Christian Kuhn commented on patch set 3 10/29/16, 11:02
ServicesListReportTest.php:51note: not strictly needed, parent::tearDown() from UnitTestCase will do that anyway. -
Christian Kuhn uploaded patch set 4 10/29/16, 11:04
-
Christian Kuhn commented on patch set 4 CR +1 V +1 10/29/16, 11:06
Please wait with a merge for a revote by Joerg. -
TYPO3com voted on patch set 4 V +1 10/29/16, 11:09 Completed build in 05m 14s on Sat, 29 Oct, 01:09 PM Test Summary: 19589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4405
-
Jörg Bösche commented on patch set 4 CR +1 V +1 10/29/16, 11:09
Thanks for the hints and the new patch set. Everything looks fine! -
Christian Kuhn voted on patch set 4 CR +2 V +2 10/29/16, 11:44
-
Gerrit merged patch set 4 10/29/16, 11:44