Review main Merged

50076[BUGFIX] Fix requiring playlist argument when "loop" is set

Wouter Wolters CR +2 V +2 Easy +10 −9 updated 10/06/16, 14:29

Commit message

The YouTubeRenderer does not force the playlist argument yet
when the loop argument is set to 1. According to the documentation
this is required for a single video player. See
https://developers.google.com/youtube/player_parameters#loop

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Jan Helke +1
    • Jörg Bösche +1
  • Verified V +2
    • Stefan Neufeind +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Wouter Wolters uploaded patch set 1 09/30/16, 12:12

  2. TYPO3com voted on patch set 1 V +1 09/30/16, 12:16 Completed build in 03m 29s on Fri, 30 Sep, 02:16 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3298

  3. Wouter Wolters updated the commit message in patch set 2 09/30/16, 12:17

  4. TYPO3com voted on patch set 2 V +1 09/30/16, 12:21 Completed build in 03m 29s on Fri, 30 Sep, 02:21 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3300

  5. Michael Oehlhof voted on patch set 2 CR +1 09/30/16, 19:16

  6. Jan Helke uploaded patch set 3 10/06/16, 10:05

  7. Jörg Bösche voted on patch set 3 CR +1 10/06/16, 10:06

  8. Jan Helke voted on patch set 3 CR +1 V +1 10/06/16, 10:06

  9. TYPO3com voted on patch set 3 V +1 10/06/16, 10:09 Completed build in 03m 15s on Thu, 6 Oct, 12:09 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3334

  10. Stefan Neufeind voted on patch set 3 CR +2 V +2 10/06/16, 14:29

  11. Gerrit merged patch set 3 10/06/16, 14:29

  12. Stefan Neufeind commented on patch set 4 10/06/16, 14:29

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 785902f64a28f9780015852ced33df5ab94f95fe