Review main Merged

50080[TASK] Rename method "JStop"" to "addCssFiles"

Michał Jankiewicz CR +2 V +2 Normal +50 −4 updated 10/07/16, 11:47

Commit message

The old name has nothing to do with JS.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Karol Lamparski +1
  • Verified V +2
    • Frank Nägler +2
    • Karol Lamparski +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1013

  1. Michał Jankiewicz uploaded patch set 1 10/01/16, 15:20

  2. TYPO3com voted on patch set 1 V +1 10/01/16, 15:23 Completed build in 03m 08s on Sat, 1 Oct, 05:23 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3305

  3. Georg Ringer commented on patch set 1 CR -1 10/01/16, 17:17

    FormResultCompiler.php:173

    as this is a public method, please deprecate the old name, add a rst for that change and use the new method in core
  4. Michał Jankiewicz uploaded patch set 2 10/01/16, 19:32

  5. TYPO3com voted on patch set 2 V +1 10/01/16, 19:36 Completed build in 03m 23s on Sat, 1 Oct, 09:35 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3309

  6. Łukasz Uznański voted on patch set 2 CR +1 V +1 10/07/16, 10:27

  7. Michał Jankiewicz uploaded patch set 3 10/07/16, 11:29

  8. TYPO3com voted on patch set 3 V +1 10/07/16, 11:33 Completed build in 03m 36s on Fri, 7 Oct, 01:33 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3365

  9. Karol Lamparski commented on patch set 3 CR +1 V +1 10/07/16, 11:37

    > Uploaded patch set 3.
  10. Frank Nägler voted on patch set 3 CR +1 10/07/16, 11:44

  11. Frank Nägler voted on patch set 3 V +1 10/07/16, 11:45

  12. Frank Nägler voted on patch set 3 CR +2 V +2 10/07/16, 11:45

  13. Gerrit merged patch set 3 10/07/16, 11:47