Review main Merged

50090[TASK] Refactor use of queryBuilder to use prepared statements

Manuel Selbach CR +2 V +2 Nightmare +3672 −1050 updated 11/20/17, 14:31

Commit message

To remove the susceptiblity to errors of SQL injections within the core
the principle of prepared statements should be followed for all queries.
Even variables which will be casted to e.g. an integer should use
setParameter(), setParameters() or createNamedParameter().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 179

Show 159 more files

Review log 2945

Show 1120 earlier messages
  1. Manuel Selbach uploaded patch set 1 10/06/16, 07:36

  2. TYPO3com voted on patch set 1 V -1 10/06/16, 07:39 Completed build in 03m 37s on Thu, 6 Oct, 09:39 AM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3327

  3. Manuel Selbach uploaded patch set 2 10/06/16, 07:47

  4. TYPO3com voted on patch set 2 V +1 10/06/16, 07:50 Completed build in 03m 17s on Thu, 6 Oct, 09:50 AM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3328

  5. Manuel Selbach uploaded patch set 3 10/07/16, 17:58

  6. TYPO3com voted on patch set 3 V +1 10/07/16, 18:02 Completed build in 03m 36s on Fri, 7 Oct, 08:02 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3405

  7. Manuel Selbach uploaded patch set 4 10/07/16, 20:23

  8. TYPO3com voted on patch set 4 V -1 10/07/16, 20:27 Completed build in 03m 48s on Fri, 7 Oct, 10:27 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3423

  9. Manuel Selbach uploaded patch set 5 10/08/16, 13:14

  10. TYPO3com voted on patch set 5 V +1 10/08/16, 13:17 Completed build in 03m 27s on Sat, 8 Oct, 03:17 PM Test Summary: 18549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3465

  11. Manuel Selbach uploaded patch set 6 10/09/16, 10:57

  12. TYPO3com voted on patch set 6 V +1 10/09/16, 11:07 Completed build in 10m 09s on Sun, 9 Oct, 01:07 PM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3515

  13. Philipp Gampe commented on patch set 6 10/09/16, 12:36

    Can split the patch into smaller chunks (e.g. by sysext). This would make it much easier to review and test the changes. You can link all patches together by giving them the same topic. Howto split patches: http://gregbabiars.com/splitting-git-commits/
  14. Manuel Selbach uploaded patch set 7 10/10/16, 20:03

  15. TYPO3com voted on patch set 7 V +1 10/10/16, 20:10 Completed build in 06m 24s on Mon, 10 Oct, 10:10 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3606

  16. Manuel Selbach uploaded patch set 8 10/14/16, 14:37

  17. TYPO3com voted on patch set 8 V +1 10/14/16, 14:49 Completed build in 11m 38s on Fri, 14 Oct, 04:49 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3774

  18. Manuel Selbach uploaded patch set 9 10/14/16, 17:38

  19. TYPO3com voted on patch set 9 V -1 10/14/16, 17:49 Completed build in 10m 52s on Fri, 14 Oct, 07:49 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3776

  20. Manuel Selbach uploaded patch set 10 10/14/16, 18:08

  1. TYPO3com voted on patch set 10 V +1 10/14/16, 18:22 Completed build in 13m 19s on Fri, 14 Oct, 08:22 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3778

  2. Manuel Selbach uploaded patch set 11 10/20/16, 10:05

  3. TYPO3com voted on patch set 11 V +1 10/20/16, 10:17 Completed build in 12m 05s on Thu, 20 Oct, 12:17 PM Test Summary: 19559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3945

  4. Anja Leichsenring uploaded patch set 12 10/25/16, 14:42

  5. TYPO3com voted on patch set 12 V +1 10/25/16, 14:55 Completed build in 11m 56s on Tue, 25 Oct, 04:55 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4160

  6. Anja Leichsenring uploaded patch set 13 10/25/16, 16:28

  7. Anja Leichsenring voted on patch set 13 CR +1 V +1 10/25/16, 16:29

  8. TYPO3com voted on patch set 13 V +1 10/25/16, 16:41 Completed build in 13m 19s on Tue, 25 Oct, 06:41 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4177

  9. Christian Kuhn commented on patch set 13 10/25/16, 19:15

    will try to read this slowly tomorrow.
  10. Christian Kuhn commented on patch set 13 CR -2 10/26/16, 07:42

    on it.
  11. Christian Kuhn uploaded patch set 14 10/26/16, 07:45

  12. TYPO3com voted on patch set 14 V +1 10/26/16, 07:56 Completed build in 10m 35s on Wed, 26 Oct, 09:56 AM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4203

  13. Christian Kuhn uploaded patch set 15 10/26/16, 11:50

  14. TYPO3com voted on patch set 15 V -1 10/26/16, 11:59 Completed build in 09m 29s on Wed, 26 Oct, 01:59 PM Test Summary: 106 of 19569 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4224

  15. Christian Kuhn uploaded patch set 16 10/26/16, 13:39

  16. TYPO3com voted on patch set 16 V +1 10/26/16, 13:49 Completed build in 10m 33s on Wed, 26 Oct, 03:49 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4231

  17. Christian Kuhn commented on patch set 16 CR 0 10/26/16, 13:50

    RteAcronymButtonRenamedToAbbreviation.php:176

    good catch.

    WorkspaceService.php:422

    the target field t3ver_state is a tinyint, so this should be a \PDO::PARAM_INT

    CleanupPreviewLinkTask.php:41

    missing execute() before ... good catch!
  18. Anja Leichsenring voted on patch set 16 CR +1 V +1 10/26/16, 13:50

  19. Christian Kuhn voted on patch set 16 CR +2 V +2 10/26/16, 13:50

  20. Gerrit merged patch set 16 10/26/16, 13:50

  21. Markus Klein commented on patch set 17 10/28/16, 20:38

    Post -1. This patch breaks filelist search. After this patch is a applied, different results (less) are returned by filelist search
  22. Markus Klein commented on patch set 17 10/28/16, 20:58

    FileIndexRepository.php:187

    bug here
  23. Markus Klein commented on patch set 17 10/28/16, 21:21

    FileIndexRepository.php

    This files contains a regression, which causes the filelist search to return less results than before. I couldn't find out which condition really is the cause. The bug commented below is not the cause for this regression.
  24. Markus Klein commented on patch set 17 10/28/16, 21:31

  25. Nicole Hummel commented on patch set 17 11/20/17, 14:31

    ExtensionRepository.php:161

    Unfortunately this creates a doubled named parameter and breaks EM functionality to sort by position index. I will push a fix asap.