Review TYPO3_7-6 Merged

50092[TASK] Clean up DebuggerUtility

Nicole Hummel CR +2 V +2 Normal +41 −32 updated 11/15/16, 20:18

Commit message

This patch cleans up the DebuggerUtility and fixing two issues:

* removes possible XSS
* makes it more readable

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Patricia Tiedemann +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Nicole Hummel uploaded patch set 1 10/06/16, 10:40

  2. TYPO3com voted on patch set 1 V +1 10/06/16, 10:41 Completed build in 01m 37s on Thu, 6 Oct, 12:41 PM Test Summary: 34918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-141

  3. Wouter Wolters voted on patch set 1 CR +1 10/06/16, 11:17

  4. Patricia Tiedemann voted on patch set 1 CR +1 10/24/16, 18:12

  5. Claus Due commented on patch set 1 10/24/16, 22:28

    This should probably read something like "[BUGFIX] Prevent dumping Closure in DebuggerUtility" because that's apparently the only thing changed. On a related note we might consider adding support for dumping closures (except of course for the 7.6 or 6.2 branches) - it's not as bad as it seems: http://www.metashock.de/2013/05/dump-source-code-of-closure-in-php/
  6. Christian Kuhn commented on patch set 1 10/27/16, 12:59

    just let's keep the commit message in 7.6 as it is in master, to keep that in sync if someone searches for it.
  7. Christian Kuhn voted on patch set 1 CR +2 V +2 10/27/16, 13:00

  8. Gerrit merged patch set 1 10/27/16, 13:00

  9. Stephan Großberndt commented on patch set 2 11/15/16, 20:18

    The backport to 6.2 is still missing. Will this be done?