50095[FEATURE] Add fluid debug information to admin panel
Commit message
Review
-
Code review CR +2
- Jan Helke +2
- Anja Leichsenring +1
-
Verified V +2
- Jan Helke +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-76085-AddFluidDebugInformationToAdminPanel.rstnew+22 −0
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+26 −0
- typo3/sysext/fluid/Classes/View/TemplatePaths.php+12 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Debug/RenderViewHelper.phpnew+124 −0
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+8 −1
- typo3/sysext/lang/locallang_tsfe.xlf+3 −0
Review log 1724
-
Anja Leichsenring uploaded patch set 1 10/06/16, 16:36
-
Anja Leichsenring commented on patch set 1 10/06/16, 16:39
this is a repush after revert of https://review.typo3.org/#/c/47678/ -
TYPO3com voted on patch set 1 V +1 10/06/16, 16:40 Completed build in 04m 00s on Thu, 6 Oct, 06:40 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3346
-
Martin Fox commented on patch set 1 CR +1 V +1 10/07/16, 18:28
Very good option -
Martin Fox commented on patch set 1 10/07/16, 18:30
-
Anja Leichsenring commented on patch set 1 V -1 10/07/16, 20:32
the patch as is introduces the same debug informations to all backend views, as long as the setting is enabled in the admin panel. Binding the option to the development context is not to my liking. If someone has access to the admin panel, he should be able to perform the debugging action, no matter what context the instance is in. Frank and Claus are informed and will take up the topic again. -
Claus Due uploaded patch set 2 10/13/16, 14:05
-
Claus Due uploaded patch set 3 10/13/16, 14:06
-
Claus Due commented on patch set 3 10/13/16, 14:07
That should do it. While I was at it I removed the context check so fluid debug shows up in production (in accordance with input from Jigal). -
TYPO3com voted on patch set 2 V +1 10/13/16, 14:13 Completed build in 08m 17s on Thu, 13 Oct, 04:13 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3721
-
TYPO3com voted on patch set 3 V +1 10/13/16, 14:17 Completed build in 11m 11s on Thu, 13 Oct, 04:17 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3723
-
Anja Leichsenring commented on patch set 4 10/24/16, 11:25
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V -1 10/24/16, 11:31 Completed build in 05m 39s on Mon, 24 Oct, 01:31 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4052
-
Anja Leichsenring commented on patch set 4 10/24/16, 11:31
not sure yet. If enabled, the JS functionality is broken. That might be considered okay, as when the debug output is enabled, one probably doesn't wishes to browse the site. But a problem remains: after activating the checkbox in Admin Panel and pressing update, nothing happens. Browser reload doesn't either. One has to clear the frontend cache in BE and then reload the page in order to see the output. Same applies to disable the setting. What to do about that? Can the FE cache be cleared automatically? -
Anja Leichsenring commented on patch set 5 10/24/16, 11:34
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 10/24/16, 11:41 Completed build in 07m 00s on Mon, 24 Oct, 01:41 PM Test Summary: 19561 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4054
-
Frank Nägler uploaded patch set 6 10/24/16, 17:07
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 10/24/16, 17:11
-
TYPO3com voted on patch set 6 V -1 10/24/16, 17:15 Completed build in 07m 35s on Mon, 24 Oct, 07:15 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4082
-
Frank Nägler uploaded patch set 7 10/24/16, 17:45
-
TYPO3com voted on patch set 7 V +1 10/24/16, 17:52 Completed build in 06m 57s on Mon, 24 Oct, 07:52 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4086
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 10/24/16, 17:53
-
Jan Helke voted on patch set 7 CR +2 V +2 10/24/16, 18:00
-
Gerrit merged patch set 7 10/24/16, 18:00