Review TYPO3_7-6 Merged

50099[BUGFIX] Do not override hidden UC fields in user settings

Markus Klein CR +2 V +2 Easy +22 −20 updated 10/07/16, 09:57

Commit message

While saving a user's uc record, all fields, which are set to disabled
in user TSconfig, are not touched anymore.
This is enforced by reducing the fields of showItem to the ones which
are allowed via user TSconfig.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 78

  1. Markus Klein commented on patch set 1 10/07/16, 09:11

    Cherry Picked from branch master.
  2. Markus Klein voted on patch set 1 CR +2 V +2 10/07/16, 09:11

  3. Gerrit merged patch set 1 10/07/16, 09:11

  4. TYPO3com commented on patch set 1 10/07/16, 09:12 Completed build in 01m 37s on Fri, 7 Oct, 11:12 AM Test Summary: 34918 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-144

  5. Łukasz Uznański commented on patch set 2 10/07/16, 09:33

    Patch dont work in TYPO3 7.6. Note from log Core: Error handler (BE): PHP Warning: Invalid argument supplied for foreach() in TYPO3.CMS/typo3/sysext/setup/Classes/Controller/SetupModuleController.php line 879
  6. Markus Klein commented on patch set 2 10/07/16, 09:40

    gnaaa... looking
  7. Markus Klein commented on patch set 2 10/07/16, 09:44

    SetupModuleController.php:841

    still used in 7.6
  8. Markus Klein commented on patch set 2 10/07/16, 09:57