Review main Merged

50102[FOLLOWUP][BUGFIX] Fix evaluation of rootLevel configuration in NewRecordController

Nicole Hummel CR +2 V +2 Easy +1 −1 updated 10/09/16, 23:20

Commit message

If there is no configuration for the rootLevel in a tables' TCA, the
NewRecordController silently assumes -1. This means a table can be
inserted on a page AND on root level. This behaviour is wrong because in
TCA documentation per default rootLevel is 0 which means, this table can
only be used on pages.
This patch sets the correct default value for rootLevel if not set.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Nicole Hummel uploaded patch set 1 10/07/16, 10:15

  2. TYPO3com voted on patch set 1 V +1 10/07/16, 10:19 Completed build in 03m 27s on Fri, 7 Oct, 12:19 PM Test Summary: 18535 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3362

  3. Wouter Wolters voted on patch set 1 CR +1 V +1 10/09/16, 13:09

  4. Stefan Neufeind voted on patch set 1 CR +2 V +2 10/09/16, 23:15

  5. Gerrit merged patch set 1 10/09/16, 23:20