Review main Merged

50104[TASK] Streamline icons (order/style) in InlineRecordContainer

Daniel Windloff CR +2 V +2 Normal +107 −57 updated 05/18/17, 13:48

Commit message

In order to be consistent, change the button order and styling
(according to the list module) in the InlineRecordContainer.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2941

Show 916 earlier messages
  1. Daniel Windloff uploaded patch set 1 10/07/16, 12:15

  2. Daniel Windloff rebased onto patch set 2 10/07/16, 12:18

  3. TYPO3com voted on patch set 1 V +1 10/07/16, 12:18 Completed build in 03m 11s on Fri, 7 Oct, 02:18 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3369

  4. TYPO3com voted on patch set 2 V +1 10/07/16, 12:22 Completed build in 03m 21s on Fri, 7 Oct, 02:22 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3370

  5. Daniel Windloff uploaded patch set 3 10/07/16, 12:27

  6. TYPO3com voted on patch set 3 V +1 10/07/16, 12:30 Completed build in 03m 30s on Fri, 7 Oct, 02:30 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3371

  7. Daniel Windloff uploaded patch set 4 10/07/16, 12:31

  8. TYPO3com voted on patch set 4 V +1 10/07/16, 12:34 Completed build in 03m 10s on Fri, 7 Oct, 02:34 PM Test Summary: 18545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3372

  9. Daniel Windloff uploaded patch set 5 10/08/16, 13:22

  10. TYPO3com voted on patch set 5 V +1 10/08/16, 13:26 Completed build in 03m 56s on Sat, 8 Oct, 03:26 PM Test Summary: 18549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3466

  11. Daniel Windloff rebased onto patch set 6 11/11/16, 15:26

  12. TYPO3com voted on patch set 6 V +1 11/11/16, 15:36 Completed build in 09m 51s on Fri, 11 Nov, 04:36 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4817

  13. Daniel Windloff rebased onto patch set 7 12/01/16, 10:20

  14. TYPO3com voted on patch set 7 V +1 12/01/16, 10:27 Completed build in 06m 58s on Thu, 1 Dec, 11:27 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5220

  15. Daniel Windloff uploaded patch set 8 12/02/16, 05:38

  16. Daniel Windloff commented on patch set 8 12/02/16, 05:43

    rebase / resolved conficts
  1. TYPO3com voted on patch set 8 V +1 12/02/16, 05:43 Completed build in 04m 10s on Fri, 2 Dec, 06:43 AM Test Summary: 54077 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5304

  2. Manuel Glauser commented on patch set 8 CR +1 V +1 12/03/16, 16:56

    InlineRecordContainer.php:446

    This double quote is probably a left-over, doesn't break the layout, though.
  3. Daniel Windloff commented on patch set 9 12/04/16, 06:37

    Published edit on patch set 8.
  4. Daniel Windloff commented on patch set 9 12/04/16, 06:38

    InlineRecordContainer.php:446 Reply

    Done
  5. TYPO3com voted on patch set 9 V +1 12/04/16, 06:41 Completed build in 04m 20s on Sun, 4 Dec, 07:41 AM Test Summary: 54298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5442

  6. Manuel Glauser voted on patch set 9 CR +1 V +1 12/04/16, 06:43

  7. Michael Oehlhof voted on patch set 9 CR +1 V +1 12/12/16, 20:15

  8. Anja Leichsenring voted on patch set 9 CR +2 V +2 12/31/16, 14:52

  9. Anja Leichsenring commented on patch set 9 CR -1 12/31/16, 14:53

    lets wait for the big fFf patch to be merged. It will be way easier to rebase this one than the other.
  10. Daniel Windloff uploaded patch set 10 01/04/17, 14:03

  11. TYPO3com voted on patch set 10 V +1 01/04/17, 14:07 Completed build in 03m 59s on Wed, 4 Jan, 03:07 PM Test Summary: 54907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6210

  12. Daniel Goerz commented on patch set 10 CR +1 V +1 01/07/17, 19:50

    Not 100% sure about the indention change for the HTML (tabs -> spaces) though
  13. Elmar Hinz commented on patch set 10 05/12/17, 11:35

    Is the big fFf patch merged meanwhile?
  14. Daniel Windloff uploaded patch set 11 05/17/17, 05:48

  15. TYPO3com voted on patch set 11 V +1 05/17/17, 05:54 Completed build in 06m 23s on Wed, 17 May, 07:54 AM Test Summary: 55850 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11527

  16. Daniel Windloff commented on patch set 11 05/17/17, 05:56

    Rebased / conficts resolved
  17. Jörg Bösche voted on patch set 11 CR +1 05/17/17, 06:37

  18. Christian Kuhn commented on patch set 11 05/18/17, 13:36

    InlineRecordContainer.php:397

    keep strict compare
  19. Christian Kuhn uploaded patch set 12 05/18/17, 13:38

  20. Jan Helke voted on patch set 12 CR +1 V +1 05/18/17, 13:40

  21. TYPO3com voted on patch set 12 V +1 05/18/17, 13:44 Completed build in 05m 31s on Thu, 18 May, 03:44 PM Test Summary: 55886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-11574

  22. Riccardo De Contardi voted on patch set 12 V +1 05/18/17, 13:47

  23. Christian Kuhn voted on patch set 12 CR +2 V +2 05/18/17, 13:48

  24. Gerrit merged patch set 12 05/18/17, 13:48

  25. Christian Kuhn commented on patch set 13 05/18/17, 13:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit cc6880050052269527f84bf4d1aa327a4d495d44