50127[BUGFIX] Change availability for the property "sword"
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Tomasz Stępniak +1
- Jan Helke +1
-
Verified V +2
- Benni Mack +2
- Tomasz Stępniak +1
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1014
-
Michał Jankiewicz uploaded patch set 1 10/08/16, 12:44
-
TYPO3com voted on patch set 1 V +1 10/08/16, 12:48 Completed build in 03m 32s on Sat, 8 Oct, 02:48 PM Test Summary: 18549 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3462
-
Benni Mack commented on patch set 1 10/08/16, 18:44
can't we use a setter - e.g. setSword() instead? -
Michał Jankiewicz uploaded patch set 2 10/09/16, 08:22
-
TYPO3com voted on patch set 2 V -1 10/09/16, 08:27 Completed build in 05m 10s on Sun, 9 Oct, 10:27 AM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3504
-
Michał Jankiewicz uploaded patch set 3 10/09/16, 09:37
-
TYPO3com voted on patch set 3 V +1 10/09/16, 09:42 Completed build in 04m 59s on Sun, 9 Oct, 11:42 AM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3507
-
Tomasz Stępniak commented on patch set 3 V -1 10/09/16, 10:31
SearchController.php:1509I think setter and getter should be public, because it not change availability of sword property -
Michał Jankiewicz uploaded patch set 4 10/09/16, 10:35
-
Jan Helke voted on patch set 4 CR +1 V +1 10/09/16, 10:37
-
Tomasz Stępniak voted on patch set 4 CR +1 V +1 10/09/16, 10:39
-
TYPO3com voted on patch set 4 V +1 10/09/16, 10:40 Completed build in 05m 07s on Sun, 9 Oct, 12:40 PM Test Summary: 19516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3512
-
Benni Mack voted on patch set 4 CR +2 V +2 10/09/16, 10:51
-
Gerrit merged patch set 4 10/09/16, 10:51