Review main Merged

50150[TASK] Improve duplicate exception code check

Christian Kuhn CR +2 V +2 Hard +290 −167 updated 10/10/16, 19:46

Commit message

* better regex finds more with less false positives
* use grep instead of ack-grep
* find exceptions without exception code
* the script kills travis for unkown reasons and removed

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 84

Show 64 more files

Review log 3049

Show 1424 earlier messages
  1. Christian Kuhn uploaded patch set 1 10/09/16, 18:09

  2. TYPO3com voted on patch set 1 V +1 10/09/16, 18:14 Completed build in 04m 58s on Sun, 9 Oct, 08:14 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3544

  3. Christian Kuhn uploaded patch set 2 10/09/16, 20:56

  4. TYPO3com voted on patch set 2 V +1 10/09/16, 21:01 Completed build in 04m 56s on Sun, 9 Oct, 11:01 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3548

  5. Christian Kuhn uploaded patch set 3 10/09/16, 21:30

  6. TYPO3com voted on patch set 3 V +1 10/09/16, 21:35 Completed build in 04m 47s on Sun, 9 Oct, 11:35 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3549

  7. Christian Kuhn uploaded patch set 4 10/09/16, 21:59

  8. TYPO3com voted on patch set 4 V +1 10/09/16, 22:04 Completed build in 04m 47s on Mon, 10 Oct, 12:04 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3550

  9. Christian Kuhn uploaded patch set 5 10/10/16, 14:36

  10. Christian Kuhn uploaded patch set 6 10/10/16, 14:38

  11. Christian Kuhn uploaded patch set 7 10/10/16, 14:38

  12. Christian Kuhn uploaded patch set 8 10/10/16, 14:39

  13. TYPO3com voted on patch set 5 V -1 10/10/16, 14:41 Completed build in 05m 11s on Mon, 10 Oct, 04:41 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3566

  14. TYPO3com voted on patch set 6 V -1 10/10/16, 14:44 Completed build in 06m 05s on Mon, 10 Oct, 04:44 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3567

  15. TYPO3com voted on patch set 7 V -1 10/10/16, 14:48 Completed build in 09m 12s on Mon, 10 Oct, 04:48 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3568

  16. TYPO3com voted on patch set 8 V -1 10/10/16, 14:48 Completed build in 08m 43s on Mon, 10 Oct, 04:48 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3569

  17. Christian Kuhn rebased onto patch set 9 10/10/16, 16:00

  18. Christian Kuhn uploaded patch set 10 10/10/16, 16:06

  19. TYPO3com voted on patch set 9 V +1 10/10/16, 16:06 Completed build in 05m 45s on Mon, 10 Oct, 06:06 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3579

  20. Christian Kuhn uploaded patch set 11 10/10/16, 16:07

  21. Christian Kuhn uploaded patch set 12 10/10/16, 16:08

  22. Christian Kuhn uploaded patch set 13 10/10/16, 16:09

  23. Christian Kuhn commented on patch set 13 10/10/16, 16:10

    patch set 11 and 12 test a missing and a duplicate exception code. bamboo should go red for them. patch set 13 should be fine. will also fire that with travis now.
  24. TYPO3com voted on patch set 10 V -1 10/10/16, 16:11 Completed build in 05m 29s on Mon, 10 Oct, 06:11 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3580

  1. TYPO3com voted on patch set 11 V -1 10/10/16, 16:15 Completed build in 07m 17s on Mon, 10 Oct, 06:15 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3581

  2. TYPO3com voted on patch set 12 V -1 10/10/16, 16:16 Completed build in 08m 20s on Mon, 10 Oct, 06:16 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3582

  3. TYPO3com voted on patch set 13 V -1 10/10/16, 16:17 Completed build in 08m 09s on Mon, 10 Oct, 06:17 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3583

  4. Christian Kuhn commented on patch set 13 CR -1 10/10/16, 16:19

    hmmm
  5. Markus Klein commented on patch set 13 10/10/16, 16:36

    First quick review

    duplicateExceptionCodeCheck.sh:17

    a

    duplicateExceptionCodeCheck.sh:25

    Comma is allowed too?

    duplicateExceptionCodeCheck.sh:25

    I'm missing a closing ] here or a \ is superfluous. What about the pipe here?

    duplicateExceptionCodeCheck.sh:25

    non-greedy should be avoided whenever possible. http://www.rexegg.com/regex-quantifiers.html#lazy_expensive Go with contrast instead. http://www.rexegg.com/regex-style.html#contrast

    duplicateExceptionCodeCheck.sh:27

    Better would be: (?:[^,]|\n)*, Not sure about the assumption here in general. What if the first parameter is itself a function call, which has parameters holding commas?

    duplicateExceptionCodeCheck.sh:28

    that does not make sense. a limited character class never needs *? as it can't eat too much.

    duplicateExceptionCodeCheck.sh:29

    duplicateExceptionCodeCheck.sh:29

    why limit with 10? Let's just use +
  6. Markus Klein commented on patch set 13 10/10/16, 16:44

    duplicateExceptionCodeCheck.sh:75

    The .* seem to be superfluous here. This rather causes the thing to go slower because a leading .* eats up the whole string and backtracks then. O(n^3)
  7. Christian Kuhn commented on patch set 13 10/10/16, 16:50

    this sucks. it seems grep or pcre or whatever returns other different output than on my machine.
  8. Christian Kuhn commented on patch set 13 10/10/16, 17:05

    duplicateExceptionCodeCheck.sh:25 Reply

    pipe here: "or nothing", there is nothing behind the or ... might be obsolete, unsure. the quote in front of ] was needed for shell ", otherwise it fails.

    duplicateExceptionCodeCheck.sh:25 Reply

    comma is allowed, the first argument might be a string with text that has comma. or a method call with arguments.

    duplicateExceptionCodeCheck.sh:25 Reply

    must be non-greedy, otherwise it may span multiple exceptions at once.

    duplicateExceptionCodeCheck.sh:27 Reply

    tried with [^,], doesn't work, see above.

    duplicateExceptionCodeCheck.sh:28 Reply

    might be, unsure.

    duplicateExceptionCodeCheck.sh:29 Reply

    unsure.

    duplicateExceptionCodeCheck.sh:29 Reply

    unsure, not too important. there shouldn't be more than 10 closing parenthesis before ;

    duplicateExceptionCodeCheck.sh:75 Reply

    shouldn't matter for a rather short single line. and i wasn't able to have only the exception code group in ${BASH_REMATCH[1]} otherwise.
  9. Christian Kuhn uploaded patch set 14 10/10/16, 18:02

  10. TYPO3com voted on patch set 14 V +1 10/10/16, 18:07 Completed build in 05m 22s on Mon, 10 Oct, 08:07 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3585

  11. Markus Klein commented on patch set 14 10/10/16, 18:09

    duplicateExceptionCodeCheck.sh:17

    a

    duplicateExceptionCodeCheck.sh:33

    needs an update for \r\n now
  12. Christian Kuhn uploaded patch set 15 10/10/16, 18:17

  13. Christian Kuhn uploaded patch set 16 10/10/16, 18:18

  14. Christian Kuhn uploaded patch set 17 10/10/16, 18:21

  15. TYPO3com voted on patch set 15 V -1 10/10/16, 18:23 Completed build in 05m 44s on Mon, 10 Oct, 08:23 PM Test Summary: 14 of 19536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3587

  16. TYPO3com voted on patch set 16 V -1 10/10/16, 18:24 Completed build in 06m 21s on Mon, 10 Oct, 08:24 PM Test Summary: 14 of 19536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3588

  17. TYPO3com voted on patch set 17 V +1 10/10/16, 18:27 Completed build in 06m 09s on Mon, 10 Oct, 08:27 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3589

  18. Christian Kuhn uploaded patch set 18 10/10/16, 18:35

  19. TYPO3com voted on patch set 18 V +1 10/10/16, 18:41 Completed build in 05m 17s on Mon, 10 Oct, 08:41 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3590

  20. Christian Kuhn uploaded patch set 19 10/10/16, 18:44

  21. Markus Klein voted on patch set 19 CR +1 V +1 10/10/16, 18:45

  22. TYPO3com voted on patch set 19 V +1 10/10/16, 18:49 Completed build in 04m 51s on Mon, 10 Oct, 08:49 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3591

  23. Wouter Wolters commented on patch set 19 CR -1 10/10/16, 19:08

    reviewing
  24. Wouter Wolters voted on patch set 19 CR +2 V +2 10/10/16, 19:46

  25. Gerrit merged patch set 19 10/10/16, 19:46