50150[TASK] Improve duplicate exception code check
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 84
- typo3/sysext/backend/Classes/Console/CliRequestHandler.php+6 −6
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+1 −1
- typo3/sysext/backend/Classes/Routing/UriBuilder.php+1 −1
- typo3/sysext/backend/Tests/Unit/Configuration/TypoScript/ConditionMatching/Fixtures/TestCondition.php+1 −1
- typo3/sysext/backend/Tests/Unit/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+4 −4
- typo3/sysext/core/Build/Scripts/duplicateExceptionCodeCheck.sh19+67 −33
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+4 −1
- typo3/sysext/core/Classes/Console/CommandRequestHandler.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+4 −1
- typo3/sysext/core/Classes/Database/Query/BulkInsertQuery.php+12 −5
- typo3/sysext/core/Classes/Error/ErrorHandler.php+1 −1
- typo3/sysext/core/Classes/ExtDirect/ExtDirectRouter.php+1 −1
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+9 −3
- typo3/sysext/core/Classes/Resource/Processing/TaskTypeRegistry.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+2 −2
- typo3/sysext/core/Classes/Tests/BaseTestCase.php+6 −3
Show 64 more files
- typo3/sysext/core/Classes/Tests/Testbase.php+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+2 −1
- typo3/sysext/core/Resources/PHP/ClassMapGenerator.php+5 −4
- typo3/sysext/core/Tests/Functional/DataHandling/Framework/ActionService.php+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Framework/DataSet.php+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php+2 −1
- typo3/sysext/core/Tests/Functional/Framework/Frontend/ResponseContent.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/FrontendDefaultFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/DebugExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Fixtures/WriterFailing.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php+10 −7
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+5 −1
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/GeneralUtilityMinifyJavaScriptFixture.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php+3 −3
- typo3/sysext/extbase/Classes/Mvc/Controller/CommandController.php+2 −2
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+4 −1
- typo3/sysext/extbase/Classes/Object/Container/ClassInfoFactory.php+4 −1
- typo3/sysext/extbase/Classes/Object/Container/Container.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapFactory.php+4 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/PersistenceManager.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Query.php+1 −1
- typo3/sysext/extbase/Classes/Property/TypeConverter/PersistentObjectConverter.php+4 −1
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+8 −2
- typo3/sysext/extbase/Classes/Reflection/ObjectAccess.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Cli/RequestBuilderTest.php+7 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/CommandControllerTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/PersistentObjectConverterTest.php+10 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Scheduler/TaskTest.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/ConfigurationController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+2 −2
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+4 −1
- typo3/sysext/extensionmanager/Classes/Utility/Importer/MirrorListUtility.php+4 −1
- typo3/sysext/extensionmanager/Classes/Utility/Parser/ExtensionXmlPullParser.php+4 −1
- typo3/sysext/extensionmanager/Tests/Unit/Controller/DownloadControllerTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Utility/FileHandlingUtilityTest.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/SwitchViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/AbstractViewHelperTest.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Form/AbstractFormFieldViewHelperTest.php+2 −2
- typo3/sysext/fluid_styled_content/Classes/ViewHelpers/Menu/CategoriesViewHelper.php+1 −1
- typo3/sysext/form/Classes/Domain/Builder/FormBuilder.php+2 −2
- typo3/sysext/form/Classes/Domain/Builder/ValidationBuilder.php+8 −2
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+2 −2
- typo3/sysext/install/Classes/Service/SqlExpectedSchemaService.php+1 −1
- typo3/sysext/install/Classes/Updates/FrontendUserImageUpdateWizard.php+5 −3
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+2 −2
- typo3/sysext/recycler/Tests/Functional/Recycle/AbstractRecycleTestCase.php+1 −1
- typo3/sysext/recycler/Tests/Unit/Task/CleanerTaskTest.php+1 −1
- typo3/sysext/rtehtmlarea/Classes/Controller/SelectImageController.php+1 −1
- typo3/sysext/scheduler/Classes/Example/TestTask.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/AbstractRecord.php+1 −1
- typo3/sysext/workspaces/Classes/Domain/Record/WorkspaceRecord.php+1 −1
- typo3/sysext/workspaces/Classes/ExtDirect/ActionHandler.php+4 −1
- typo3/sysext/workspaces/Classes/ExtDirect/MassActionHandler.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+1 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php+12 −3
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+1 −1
- .travis.yml+1 −6
Review log 3049
Show 1424 earlier messages
-
Christian Kuhn uploaded patch set 1 10/09/16, 18:09
-
TYPO3com voted on patch set 1 V +1 10/09/16, 18:14 Completed build in 04m 58s on Sun, 9 Oct, 08:14 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3544
-
Christian Kuhn uploaded patch set 2 10/09/16, 20:56
-
TYPO3com voted on patch set 2 V +1 10/09/16, 21:01 Completed build in 04m 56s on Sun, 9 Oct, 11:01 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3548
-
Christian Kuhn uploaded patch set 3 10/09/16, 21:30
-
TYPO3com voted on patch set 3 V +1 10/09/16, 21:35 Completed build in 04m 47s on Sun, 9 Oct, 11:35 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3549
-
Christian Kuhn uploaded patch set 4 10/09/16, 21:59
-
TYPO3com voted on patch set 4 V +1 10/09/16, 22:04 Completed build in 04m 47s on Mon, 10 Oct, 12:04 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3550
-
Christian Kuhn uploaded patch set 5 10/10/16, 14:36
-
Christian Kuhn uploaded patch set 6 10/10/16, 14:38
-
Christian Kuhn uploaded patch set 7 10/10/16, 14:38
-
Christian Kuhn uploaded patch set 8 10/10/16, 14:39
-
TYPO3com voted on patch set 5 V -1 10/10/16, 14:41 Completed build in 05m 11s on Mon, 10 Oct, 04:41 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3566
-
TYPO3com voted on patch set 6 V -1 10/10/16, 14:44 Completed build in 06m 05s on Mon, 10 Oct, 04:44 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3567
-
TYPO3com voted on patch set 7 V -1 10/10/16, 14:48 Completed build in 09m 12s on Mon, 10 Oct, 04:48 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3568
-
TYPO3com voted on patch set 8 V -1 10/10/16, 14:48 Completed build in 08m 43s on Mon, 10 Oct, 04:48 PM Test Summary: 19474 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3569
-
Christian Kuhn rebased onto patch set 9 10/10/16, 16:00
-
Christian Kuhn uploaded patch set 10 10/10/16, 16:06
-
TYPO3com voted on patch set 9 V +1 10/10/16, 16:06 Completed build in 05m 45s on Mon, 10 Oct, 06:06 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3579
-
Christian Kuhn uploaded patch set 11 10/10/16, 16:07
-
Christian Kuhn uploaded patch set 12 10/10/16, 16:08
-
Christian Kuhn uploaded patch set 13 10/10/16, 16:09
-
Christian Kuhn commented on patch set 13 10/10/16, 16:10
patch set 11 and 12 test a missing and a duplicate exception code. bamboo should go red for them. patch set 13 should be fine. will also fire that with travis now. -
TYPO3com voted on patch set 10 V -1 10/10/16, 16:11 Completed build in 05m 29s on Mon, 10 Oct, 06:11 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3580
-
TYPO3com voted on patch set 11 V -1 10/10/16, 16:15 Completed build in 07m 17s on Mon, 10 Oct, 06:15 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3581
-
TYPO3com voted on patch set 12 V -1 10/10/16, 16:16 Completed build in 08m 20s on Mon, 10 Oct, 06:16 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3582
-
TYPO3com voted on patch set 13 V -1 10/10/16, 16:17 Completed build in 08m 09s on Mon, 10 Oct, 06:17 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3583
-
Christian Kuhn commented on patch set 13 CR -1 10/10/16, 16:19
hmmm -
Markus Klein commented on patch set 13 10/10/16, 16:36
First quick reviewduplicateExceptionCodeCheck.sh:17aduplicateExceptionCodeCheck.sh:25Comma is allowed too?duplicateExceptionCodeCheck.sh:25I'm missing a closing ] here or a \ is superfluous. What about the pipe here?duplicateExceptionCodeCheck.sh:25non-greedy should be avoided whenever possible. http://www.rexegg.com/regex-quantifiers.html#lazy_expensive Go with contrast instead. http://www.rexegg.com/regex-style.html#contrastduplicateExceptionCodeCheck.sh:27Better would be: (?:[^,]|\n)*, Not sure about the assumption here in general. What if the first parameter is itself a function call, which has parameters holding commas?duplicateExceptionCodeCheck.sh:28that does not make sense. a limited character class never needs *? as it can't eat too much.duplicateExceptionCodeCheck.sh:29(?:(?!\)+;).)*\)+;$ http://www.rexegg.com/regex-quantifiers.html#tempered_greedduplicateExceptionCodeCheck.sh:29why limit with 10? Let's just use + -
Markus Klein commented on patch set 13 10/10/16, 16:44
duplicateExceptionCodeCheck.sh:75The .* seem to be superfluous here. This rather causes the thing to go slower because a leading .* eats up the whole string and backtracks then. O(n^3) -
Christian Kuhn commented on patch set 13 10/10/16, 16:50
this sucks. it seems grep or pcre or whatever returns other different output than on my machine. -
Christian Kuhn commented on patch set 13 10/10/16, 17:05
duplicateExceptionCodeCheck.sh:25Replypipe here: "or nothing", there is nothing behind the or ... might be obsolete, unsure. the quote in front of ] was needed for shell ", otherwise it fails.duplicateExceptionCodeCheck.sh:25Replycomma is allowed, the first argument might be a string with text that has comma. or a method call with arguments.duplicateExceptionCodeCheck.sh:25Replymust be non-greedy, otherwise it may span multiple exceptions at once.duplicateExceptionCodeCheck.sh:27Replytried with [^,], doesn't work, see above.duplicateExceptionCodeCheck.sh:28Replymight be, unsure.duplicateExceptionCodeCheck.sh:29Replyunsure.duplicateExceptionCodeCheck.sh:29Replyunsure, not too important. there shouldn't be more than 10 closing parenthesis before ;duplicateExceptionCodeCheck.sh:75Replyshouldn't matter for a rather short single line. and i wasn't able to have only the exception code group in ${BASH_REMATCH[1]} otherwise. -
Christian Kuhn uploaded patch set 14 10/10/16, 18:02
-
TYPO3com voted on patch set 14 V +1 10/10/16, 18:07 Completed build in 05m 22s on Mon, 10 Oct, 08:07 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3585
-
Markus Klein commented on patch set 14 10/10/16, 18:09
duplicateExceptionCodeCheck.sh:17aduplicateExceptionCodeCheck.sh:33needs an update for \r\n now -
Christian Kuhn uploaded patch set 15 10/10/16, 18:17
-
Christian Kuhn uploaded patch set 16 10/10/16, 18:18
-
Christian Kuhn uploaded patch set 17 10/10/16, 18:21
-
TYPO3com voted on patch set 15 V -1 10/10/16, 18:23 Completed build in 05m 44s on Mon, 10 Oct, 08:23 PM Test Summary: 14 of 19536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3587
-
TYPO3com voted on patch set 16 V -1 10/10/16, 18:24 Completed build in 06m 21s on Mon, 10 Oct, 08:24 PM Test Summary: 14 of 19536 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3588
-
TYPO3com voted on patch set 17 V +1 10/10/16, 18:27 Completed build in 06m 09s on Mon, 10 Oct, 08:27 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3589
-
Christian Kuhn uploaded patch set 18 10/10/16, 18:35
-
TYPO3com voted on patch set 18 V +1 10/10/16, 18:41 Completed build in 05m 17s on Mon, 10 Oct, 08:41 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3590
-
Christian Kuhn uploaded patch set 19 10/10/16, 18:44
-
Markus Klein voted on patch set 19 CR +1 V +1 10/10/16, 18:45
-
TYPO3com voted on patch set 19 V +1 10/10/16, 18:49 Completed build in 04m 51s on Mon, 10 Oct, 08:49 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3591
-
Wouter Wolters commented on patch set 19 CR -1 10/10/16, 19:08
reviewing -
Wouter Wolters voted on patch set 19 CR +2 V +2 10/10/16, 19:46
-
Gerrit merged patch set 19 10/10/16, 19:46