50157[TASK] Deprecate frameset and frame
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1115
-
Daniel Windloff uploaded patch set 1 10/10/16, 10:38
-
TYPO3com voted on patch set 1 V +1 10/10/16, 10:43 Completed build in 05m 14s on Mon, 10 Oct, 12:43 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3561
-
Wouter Wolters voted on patch set 1 CR +1 10/27/16, 12:22
-
Christian Kuhn rebased onto patch set 2 10/27/16, 12:26
-
Christian Kuhn commented on patch set 2 10/27/16, 12:27
-
Christian Kuhn commented on patch set 2 10/27/16, 12:30
Deprecation-78217-FramesetAndFrame.rst:122 sentences please.Deprecation-78217-FramesetAndFrame.rst:19config.frameReloadIfNotInFrameset please, that's more obvious.Deprecation-78217-FramesetAndFrame.rst:20config.Deprecation-78217-FramesetAndFrame.rst:21config.PageGenerator.php:151this will catch xhtml_trans and xhtml_strict, too. i guess that's not intended?! -
TYPO3com voted on patch set 2 V -1 10/27/16, 12:31 Completed build in 04m 52s on Thu, 27 Oct, 02:31 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4326
-
Daniel Windloff uploaded patch set 3 10/27/16, 12:58
-
TYPO3com voted on patch set 3 V -1 10/27/16, 13:03 Completed build in 04m 38s on Thu, 27 Oct, 03:03 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4330
-
Wouter Wolters commented on patch set 4 10/27/16, 13:04
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 10/27/16, 13:09 Completed build in 04m 57s on Thu, 27 Oct, 03:09 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4331
-
Wouter Wolters voted on patch set 4 CR +1 10/27/16, 13:30
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 10/27/16, 13:36
-
Christian Kuhn voted on patch set 4 CR +2 V +2 10/27/16, 13:40
-
Gerrit merged patch set 4 10/27/16, 13:40
Deprecation-78217-FramesetAndFrame.rst:48