Review main Merged

50157[TASK] Deprecate frameset and frame

Daniel Windloff CR +2 V +2 Normal +67 −1 updated 10/27/16, 13:40

Commit message

HTML5 does not support frame and frameset anymore.
Deprecate TypoScript that can be used to create a
markup based on frameset.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1115

  1. Daniel Windloff uploaded patch set 1 10/10/16, 10:38

  2. TYPO3com voted on patch set 1 V +1 10/10/16, 10:43 Completed build in 05m 14s on Mon, 10 Oct, 12:43 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3561

  3. Wouter Wolters voted on patch set 1 CR +1 10/27/16, 12:22

  4. Christian Kuhn rebased onto patch set 2 10/27/16, 12:26

  5. Christian Kuhn commented on patch set 2 10/27/16, 12:27

    Deprecation-78217-FramesetAndFrame.rst:48

    index missing, bamboo will report in a minute.
  6. Christian Kuhn commented on patch set 2 10/27/16, 12:30

    Deprecation-78217-FramesetAndFrame.rst:12

    2 sentences please.

    Deprecation-78217-FramesetAndFrame.rst:19

    config.frameReloadIfNotInFrameset please, that's more obvious.

    Deprecation-78217-FramesetAndFrame.rst:20

    config.

    Deprecation-78217-FramesetAndFrame.rst:21

    config.

    PageGenerator.php:151

    this will catch xhtml_trans and xhtml_strict, too. i guess that's not intended?!
  7. TYPO3com voted on patch set 2 V -1 10/27/16, 12:31 Completed build in 04m 52s on Thu, 27 Oct, 02:31 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4326

  8. Daniel Windloff uploaded patch set 3 10/27/16, 12:58

  9. TYPO3com voted on patch set 3 V -1 10/27/16, 13:03 Completed build in 04m 38s on Thu, 27 Oct, 03:03 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4330

  10. Wouter Wolters commented on patch set 4 10/27/16, 13:04

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 4 V +1 10/27/16, 13:09 Completed build in 04m 57s on Thu, 27 Oct, 03:09 PM Test Summary: 19569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4331

  12. Wouter Wolters voted on patch set 4 CR +1 10/27/16, 13:30

  13. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/27/16, 13:36

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 10/27/16, 13:40

  15. Gerrit merged patch set 4 10/27/16, 13:40