Review main Merged Breaking

50166[!!!][FEATURE] Move generated autoload info to typo3conf

Helmut Hummel CR +2 V +2 Normal +141 −5 updated 10/10/16, 21:53

Commit message

It turned out to be misleading, that additional class loading
information of extensions (in non composer mode) is in the
typo3temp folder. These files were re-generated on the fly to
lower the impact of the new class loader. However the re-generation
can only be triggered at a late point during the bootstrap.

This caused issues, when extensions tried to hook in a earlier point
e.g. for providing an error or exception handler and removing the complete
typo3temp folder e.g. in deployment scenarios.

To make clear, that class loading information is not a cache,
it is moved to typo3conf.
Additionally the re-generation during the late bootstrap
now triggers a deprecation message.

Additionally to make it easy for users that are not familiar with
executing command line scripts, an action is added to the install tool
to dump autoload information.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Andreas Kienast +1
    • Jigal van Hemert +1
  • Verified V +2
    • Nicole Hummel +2
    • Andreas Kienast +1
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1820

  1. Helmut Hummel uploaded patch set 1 10/10/16, 17:48

  2. TYPO3com voted on patch set 1 V +1 10/10/16, 17:52 Completed build in 04m 44s on Mon, 10 Oct, 07:52 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3584

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 10/10/16, 18:01

  4. Markus Klein commented on patch set 1 10/10/16, 18:06

    Breaking-78222-ExtensionAutoloadInformationIsNowInTypo3confautoload.rst:13

    dot missing

    Breaking-78222-ExtensionAutoloadInformationIsNowInTypo3confautoload.rst:38

    Tags missing?

    ImportantActions.php:235

    return type annotation missing
  5. Christian Kuhn commented on patch set 1 10/10/16, 18:08

    this will give headaches again on multi server environments where typo3temp is shared but typo3conf is not (which is a good thing: typo3/ or typo3conf/ on something like nfs is a bad idea TM). nfs scenarious tend to often move the typo3temp/ php cache files out again with a link-hack. if we now create a dyn file in typo3conf/ again, this will add more issues to my feeling.
  6. Markus Klein commented on patch set 1 10/10/16, 18:11

    Not sure Christian what you mean. The files are not dynamic, but only change if extensions are modified. That must be done per server anyways.
  7. Christian Kuhn commented on patch set 1 10/10/16, 18:12

    don't get me wrong, i see the benefits. having the file itself in an own directory helps, though. still i think we should at least explain a bit how people should deal with multi-head env's and a local typo3conf/ dir in those cases.
  8. Helmut Hummel commented on patch set 1 10/10/16, 19:38

    @Christian: don't you think that multi head scenarios will be solved with a composer based TYPO3 installation? This change will only affect non composer mode TYPO3 installs
  9. Christian Kuhn commented on patch set 1 10/10/16, 19:43

    advantages: * characteristics of autoload file are much nearer to packageStates and localconf that to a cache file * the patch simplifies deployment and maybe handy for people who want to check in this stuff into version control for whatever reason * there is no real drawback since the install tool and bootstrap and em write other files in typo3conf/ too. disadvantages: * it might be slightly more annoying for multi-head scenarios in non-composer, but there should are solutions to circumvent -> fine with me.
  10. Helmut Hummel commented on patch set 1 10/10/16, 19:45

    > where typo3temp is shared but typo3conf is not Oh, and I see benefits here in case someone really wants to go non composer and cloud with TYPO3 because then this change will give a performance boost, because the static! class loading info can easily reside on each node. But yes, multi head, non shared typo3conf, AND "deployment" with extension manager will result in trouble. If this is a 80% use case (which I doubt), then we should probably avoid this change.
  11. Helmut Hummel commented on patch set 1 10/10/16, 19:47

    @Christian: since you mention PackageStates.php A multi head scenario with EM "deployment" will not work anyway because of exactly this file. Oh and there is LocalConfiguration.php with serialized extension configuration. So moving the autoload info there will not cause any additional headache, would it ;)
  12. Jigal van Hemert commented on patch set 1 10/10/16, 19:48

    Breaking-78222-ExtensionAutoloadInformationIsNowInTypo3confautoload.rst:13 Reply

    Done

    Breaking-78222-ExtensionAutoloadInformationIsNowInTypo3confautoload.rst:38 Reply

    Which tags should be included here? Can't really find really fitting tags for this change.

    ImportantActions.php:235 Reply

    Done
  13. Jigal van Hemert uploaded patch set 2 10/10/16, 19:49

  14. Helmut Hummel commented on patch set 1 10/10/16, 19:50

    @Christian: uhm, right I think we agree here :) Thanks
  15. TYPO3com voted on patch set 2 V +1 10/10/16, 19:57 Completed build in 07m 36s on Mon, 10 Oct, 09:57 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3604

  16. Nicole Hummel voted on patch set 2 CR +1 10/10/16, 19:59

  17. Andreas Kienast voted on patch set 2 CR +1 V +1 10/10/16, 21:11

  18. Jigal van Hemert voted on patch set 2 CR +1 V +1 10/10/16, 21:11

  19. Nicole Hummel voted on patch set 2 CR +2 V +2 10/10/16, 21:53

  20. Gerrit merged patch set 2 10/10/16, 21:53