Review main Merged

50169[BUGFIX] Do not provide non selectable columns in colPos selector

Helmut Hummel CR +2 V +2 Easy +3 −0 updated 10/14/16, 09:43

Commit message

When a backend layout is active for a page, editing a content
element will have the "columns" of this layout selectable
in the "colPos" drop down selector.

Now this select box does not include the backend layout columns without
assigned colPos any more, because these are not meant to have content
anyway and selecting such a column would put the content element into column
with colPos 0

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Sommer +1
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Sommer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Helmut Hummel uploaded patch set 1 10/10/16, 18:04

  2. TYPO3com voted on patch set 1 V +1 10/10/16, 18:09 Completed build in 05m 04s on Mon, 10 Oct, 08:09 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3586

  3. Frank Nägler voted on patch set 1 CR +1 V +1 10/12/16, 13:44

  4. Wouter Wolters voted on patch set 1 CR +1 10/13/16, 19:53

  5. Markus Sommer commented on patch set 1 CR +1 V +1 10/14/16, 09:40

    Only works if you set it with the backend layout data provider not via backend data
  6. Frank Nägler voted on patch set 1 CR +2 V +2 10/14/16, 09:43

  7. Gerrit merged patch set 1 10/14/16, 09:43

  8. Frank Nägler commented on patch set 2 10/14/16, 09:43

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 2b23a0d67091247c6faf1b7238f7d376d5bd9505