Review main Merged

50177[TASK] Deprecate DatabaseConnection based prepared statements in Extbase

Benni Mack CR +2 V +2 Easy +35 −0 updated 12/31/16, 14:09

Commit message

Extbase has a way to set raw statements with PreparedStatements
based on DatabaseConnection. This functionality has been marked
as deprecated as Doctrine DBAL shows a superior way of doing
so natively within the database directly.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Morton Jonuschat +1
  • Verified V +2
    • Anja Leichsenring +2
    • Morton Jonuschat +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Benni Mack uploaded patch set 1 10/10/16, 19:16

  2. TYPO3com voted on patch set 1 V +1 10/10/16, 19:22 Completed build in 05m 46s on Mon, 10 Oct, 09:21 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3596

  3. Benni Mack wrote 10/11/16, 12:13

    Topic set to doctrine
  4. Frank Nägler voted on patch set 1 CR +1 10/11/16, 13:41

  5. Frank Nägler voted on patch set 1 V +1 10/11/16, 13:45

  6. Benni Mack commented on patch set 1 10/11/16, 14:02

    we need to check the todos (see the commit message)
  7. Christian Kuhn commented on patch set 1 CR -1 10/11/16, 16:46

    todo after 8.4 release
  8. Benni Mack uploaded patch set 2 12/13/16, 19:48

  9. Benni Mack commented on patch set 2 CR -2 12/13/16, 19:48

    reworked the patch ready for 8.6
  10. TYPO3com voted on patch set 2 V -1 12/13/16, 19:52 Completed build in 03m 44s on Tue, 13 Dec, 08:52 PM Test Summary: 54391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5748

  11. Benni Mack voted on patch set 2 CR 0 12/29/16, 13:51

  12. Benni Mack commented on patch set 3 12/29/16, 13:52

    Published edit on patch set 2.
  13. TYPO3com voted on patch set 3 V +1 12/29/16, 13:56 Completed build in 04m 44s on Thu, 29 Dec, 02:56 PM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6040

  14. Susi Moog voted on patch set 3 CR +1 12/30/16, 14:05

  15. Morton Jonuschat updated the commit message in patch set 4 12/31/16, 05:04

  16. Morton Jonuschat voted on patch set 4 CR +1 V +1 12/31/16, 05:04

  17. TYPO3com voted on patch set 4 V +1 12/31/16, 05:09 Completed build in 04m 40s on Sat, 31 Dec, 06:09 AM Test Summary: 54417 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6100

  18. Anja Leichsenring voted on patch set 4 CR +2 V +2 12/31/16, 14:09

  19. Gerrit merged patch set 4 12/31/16, 14:09