Review main Merged

50180[BUGFIX] Prevent crash in Install Tool and EM with invalid ext_tables.sql

Xavier Perseguers CR +2 V +2 Easy +26 −3 updated 10/13/16, 14:04

Commit message

If a parsing exception is thrown, this exception is now catched and the
error message is being displayed as a flash message along with
contextual information.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Christian Kuhn +1
  • Verified V +2
    • Morton Jonuschat +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1317

  1. Xavier Perseguers uploaded patch set 1 10/11/16, 07:55

  2. Xavier Perseguers updated the commit message in patch set 2 10/11/16, 07:56

  3. TYPO3com voted on patch set 1 V +1 10/11/16, 08:01 Completed build in 05m 44s on Tue, 11 Oct, 10:01 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3613

  4. TYPO3com voted on patch set 2 V +1 10/11/16, 08:03 Completed build in 06m 39s on Tue, 11 Oct, 10:03 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3614

  5. Mathias Schreiber updated the commit message in patch set 3 10/11/16, 08:06

  6. Mathias Schreiber commented on patch set 3 CR +1 V +1 10/11/16, 08:09

    putting in invalid sql to test is easier than I thought :)
  7. TYPO3com voted on patch set 3 V +1 10/11/16, 08:11 Completed build in 04m 24s on Tue, 11 Oct, 10:11 AM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3615

  8. Wouter Wolters commented on patch set 3 CR -1 10/11/16, 08:14

    Please give Morton a chance to review this one. Thanks
  9. Christian Kuhn commented on patch set 3 CR -1 10/11/16, 12:48

  10. Christian Kuhn commented on patch set 3 10/11/16, 13:02

    i'm fine with the patch in general, way to go. Wouter, I think there is not much Morton could not be satisfied with here: the exception flow is implemented at the correct places. we may only think about not throwing the same exception again, but a specific different one. but that's arguably and has no huge benefits. I think the solution is fine, if: * catch \Exception() is changed to a specific catch * the extension manager suffers from the same issue (try to load an ext with faulty ext_tables.sql). i think we should fix that at the same time
  11. Xavier Perseguers commented on patch set 3 10/13/16, 06:24

    @Christian: will have a look for EM. This is not the same bug anymore since my use case was being unable to run the upgrade wizard or compare tool, something that you must do after an upgrade and that will automatically fix the bug in EM as a consequence but of course, if I find that the EM is easy to fix similarly I may include the fix as well. Regarding the specific catch, will do that but generally speaking I'm not fan of not catching exception in the install tool, this is something that is expected to be as solid as rock and should ideally never crash but instead report problems in some "user-friendly manner". After all that's the entry point to TYPO3 for new users as well.
  12. Xavier Perseguers uploaded patch set 4 10/13/16, 06:34

  13. TYPO3com voted on patch set 4 V +1 10/13/16, 06:40 Completed build in 06m 16s on Thu, 13 Oct, 08:40 AM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3689

  14. Wouter Wolters commented on patch set 4 10/13/16, 07:46

    I just remember Morton saying on T3DD16 that there was something with this situation. But can't remember exactly what is was. That why I asked for a review by Morton.
  15. Christian Kuhn commented on patch set 4 CR +1 V +1 10/13/16, 13:38

    review & tested. nicely done! pinged morton, he'll have a look, too.
  16. Morton Jonuschat voted on patch set 4 CR +2 V +2 10/13/16, 14:04

  17. Gerrit merged patch set 4 10/13/16, 14:04