Review main Merged

50184[BUGFIX] Bind the cHash to the id of the "real" page

Helmut Hummel CR +2 V +2 Easy +10 −10 updated 11/15/16, 09:48

Commit message

If a link to a mount point or a shortcut is created,
the id argument in the url points to the id of the real page,
where the mount or the shortcut points to.

This is why we need to take the id of the final page
to be hashed and not the one used to generate the link.

We also need to move cHash calculation below shortcut resolving.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1821

  1. Helmut Hummel uploaded patch set 1 10/11/16, 13:05

  2. Mathias Brodala voted on patch set 1 CR +1 10/11/16, 13:07

  3. TYPO3com voted on patch set 1 V +1 10/11/16, 13:10 Completed build in 05m 06s on Tue, 11 Oct, 03:10 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3623

  4. Guillaume Germain voted on patch set 1 V +1 10/11/16, 13:12

  5. Wouter Wolters voted on patch set 1 CR +1 10/13/16, 07:55

  6. Markus Klein commented on patch set 1 10/31/16, 23:45

    ContentObjectRenderer.php:5969

    $page might be modified here again after we followed shortcuts. Do we need to move the cHash generation below this?
  7. Helmut Hummel commented on patch set 1 10/31/16, 23:46

    ContentObjectRenderer.php:5969 Reply

    might be. This would be a different bug to be fixed though. Do you have a test case for that?
  8. Markus Klein commented on patch set 1 11/01/16, 00:27

    ContentObjectRenderer.php:5969 Reply

    No test case at hand. But I don't see why this would be a different bug? Before the sec fix, no id was needed for cHash, so the position of the calculation didn't matter. Now we have to walk the whole way to the effective target page and add this id for the cHash, right?
  9. Helmut Hummel uploaded patch set 2 11/10/16, 12:19

  10. Helmut Hummel updated the commit message in patch set 3 11/10/16, 12:23

  11. Helmut Hummel commented on patch set 1 11/10/16, 12:23

    ContentObjectRenderer.php:5969 Reply

    you are right. I fixed that with patch set 3
  12. TYPO3com voted on patch set 2 V +1 11/10/16, 12:26 Completed build in 06m 56s on Thu, 10 Nov, 01:26 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4765

  13. TYPO3com voted on patch set 3 V +1 11/10/16, 12:33 Completed build in 10m 04s on Thu, 10 Nov, 01:33 PM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4766

  14. Markus Klein voted on patch set 3 CR +1 11/10/16, 12:38

  15. Wouter Wolters commented on patch set 3 11/10/16, 14:18

    ContentObjectRenderer.php:5977

    !== here?
  16. Helmut Hummel commented on patch set 3 11/10/16, 14:38

    ContentObjectRenderer.php:5977 Reply

    actually this check is broken (was broken before). Shall I fix this in this commit, although it is a different topic, or should I create a separate change request for that?
  17. Wouter Wolters commented on patch set 3 CR +1 11/10/16, 14:45

    fix it with a different patch IMO, was already wrong before.
  18. Markus Klein voted on patch set 3 V +1 11/12/16, 17:20

  19. Stefan Neufeind commented on patch set 3 CR +2 V +2 11/12/16, 23:45

    Looked in the code that we also have the same code down to 6.2 as well.

    ContentObjectRenderer.php:5977 Reply

    discussed with Markus. Let's look closer into that as a separate fix, not here. During testing I also encountered some oddities we might at least want to look at.
  20. Gerrit merged patch set 3 11/12/16, 23:45

  21. Oliver Hader commented on patch set 4 11/15/16, 09:48

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-4 as commit e4b5646a99b3bbbf011cdfae12ec39331ef022c4