Review main Merged

50190[FEATURE] Display (un)substituted TS constant

anonymized-50850 CR +2 V +2 Easy +38 −8 updated 12/09/17, 21:06

Commit message

Display value of TS constants on "UN-substituted constants in green"
mode and constant name when on "Substituted constant in green" mode.

Before this patch toggling between both modes was necessary to simply
get an idea of what the value/variable name was while being on the
'other' mode.

As a side effect this patch improves the search feature of the object
browser when searching for a constant value or name, i.e. 'maxWInText'
while being on "Substituted" mode.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1219

  1. anonymized-50850 uploaded patch set 1 10/11/16, 21:33

  2. TYPO3com voted on patch set 1 V -1 10/11/16, 21:39 Completed build in 06m 00s on Tue, 11 Oct, 11:39 PM Test Summary: 19536 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3658

  3. Anja Leichsenring updated the commit message in patch set 2 12/08/16, 18:40

  4. Anja Leichsenring commented on patch set 2 12/08/16, 18:40

    Features may only be merged to master. It misses an rst documentation file (see https://forger.typo3.org/utility/rst)
  5. TYPO3com voted on patch set 2 V -1 12/08/16, 18:45 Completed build in 04m 52s on Thu, 8 Dec, 07:44 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5609

  6. anonymized-50850 uploaded patch set 3 12/13/16, 12:04

  7. TYPO3com voted on patch set 3 V -1 12/13/16, 12:09 Completed build in 04m 13s on Tue, 13 Dec, 01:08 PM Test Summary: 54373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5730

  8. Georg Ringer uploaded patch set 4 12/21/16, 11:10

  9. TYPO3com voted on patch set 4 V +1 12/21/16, 11:15 Completed build in 04m 46s on Wed, 21 Dec, 12:15 PM Test Summary: 54399 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5907

  10. Benni Mack commented on patch set 4 11/29/17, 00:19

    ping. please rebase.
  11. Sebastian Hofer uploaded patch set 5 11/29/17, 15:57

  12. TYPO3com voted on patch set 5 V +1 11/29/17, 16:11 Completed build in 14m 35s on Wed, 29 Nov, 05:11 PM Test Summary: 57000 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-16977

  13. Benni Mack commented on patch set 6 12/09/17, 20:31

    Published edit on patch set 5.
  14. TYPO3com voted on patch set 6 V +1 12/09/17, 20:44 Completed build in 13m 37s on Sat, 9 Dec, 09:44 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17487

  15. Benni Mack uploaded patch set 7 12/09/17, 20:52

  16. Benni Mack voted on patch set 7 CR +1 V +1 12/09/17, 20:53

  17. TYPO3com voted on patch set 7 V +1 12/09/17, 21:02 Completed build in 09m 38s on Sat, 9 Dec, 10:02 PM Test Summary: 57053 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-17489

  18. Susi Moog voted on patch set 7 CR +2 V +2 12/09/17, 21:06

  19. Gerrit merged patch set 7 12/09/17, 21:06