Review main Merged

50192Revert "[BUGFIX] Do not turn storages automatically offline"

Helmut Hummel CR +2 V +2 Normal +43 −29 updated 10/17/16, 12:23

Commit message

This reverts commit 157e1f269902c9b3ab57c95f71534949606fc658.

This change introduced bugs with storages that were explicitly marked offline. 
Besides that, it removed pubic API without deprecation
and lacked (clearly documented) concept on the behavior in the error case.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 1

Review log 610

  1. Helmut Hummel uploaded patch set 1 10/12/16, 10:36

  2. TYPO3com voted on patch set 1 V -1 10/12/16, 10:37 Completed build in 10s on Wed, 12 Oct, 12:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3664

  3. Helmut Hummel uploaded patch set 2 10/12/16, 10:47

  4. TYPO3com voted on patch set 2 V +1 10/12/16, 10:53 Completed build in 05m 12s on Wed, 12 Oct, 12:52 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3665

  5. Helmut Hummel updated the commit message in patch set 3 10/12/16, 10:53

  6. TYPO3com voted on patch set 3 V +1 10/12/16, 10:58 Completed build in 05m 15s on Wed, 12 Oct, 12:58 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3666

  7. Benni Mack updated the commit message in patch set 4 10/17/16, 12:19

  8. Benni Mack commented on patch set 4 CR +2 V +2 10/17/16, 12:21

    This reverts the change for 8.4 for now, so the old behaviour is back. New ideas on how to solve this are explicitly wanted :)
  9. Gerrit merged patch set 4 10/17/16, 12:21

  10. TYPO3com commented on patch set 4 10/17/16, 12:23 Completed build in 04m 23s on Mon, 17 Oct, 02:23 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3835