Review main Abandoned Breaking

50200[WIP][!!!][FEATURE] Improve cache hash API and security

Helmut Hummel CR 0 V 0 Normal +32 −62 updated 03/06/18, 10:02

Commit message

The Cache Hash API introduced an option to include the
pageID to prevent cache flooding with a recent security
bugfix.

The new TYPO3 v8 should have this option enabled without
any option to disable this functionality. The patch
thus removes the option and functionality completely.

The status report in the reports module is removed as well.

What is missing:
- SilentConfigurationUpdater should remove the TYPO3_CONF_VARS setting
- Breaking RST that all configured cHash variant without the pageID calculated are not working anymore
- Breaking RST that the option is removed.

Review

  • Code review CR 0
  • Verified V 0

Files 8

Review log 46

  1. Helmut Hummel uploaded patch set 1 10/12/16, 19:07

  2. TYPO3com voted on patch set 1 V -1 10/12/16, 19:12 Completed build in 05m 22s on Wed, 12 Oct, 09:12 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3681

  3. Benni Mack uploaded patch set 2 11/14/16, 10:25

  4. TYPO3com voted on patch set 2 V +1 11/14/16, 10:36 Completed build in 10m 50s on Mon, 14 Nov, 11:36 AM Test Summary: 55265 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4914

  5. Benni Mack commented on patch set 2 12/08/17, 10:54

    Helmut, this one is resolved with ticket #80050 right? So we can close this ticket?
  6. Helmut Hummel abandoned the change 03/06/18, 10:02