Review main Merged

50210[TASK] Deprecate property iframe in TYPO3.Backend.ContentContainer

Frank Nägler CR +2 V +2 Easy +39 −4 updated 10/18/16, 14:17

Commit message

Deprecate the property top.TYPO3.Backend.ContentContainer.iframe
and introduce an accessor method.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Daniel Goerz +1
  • Verified V +2
    • Wouter Wolters +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 1317

  1. Frank Nägler uploaded patch set 1 10/13/16, 10:34

  2. Frank Nägler commented on patch set 1 CR -2 10/13/16, 10:35

    wait with this patch until 8.4 is released
  3. Frank Nägler updated the commit message in patch set 2 10/13/16, 10:36

  4. Wouter Wolters updated the commit message in patch set 3 10/13/16, 10:37

  5. Wouter Wolters voted on patch set 3 CR +1 10/13/16, 10:37

  6. Daniel Goerz voted on patch set 3 CR +1 V +1 10/13/16, 10:39

  7. Daniel Goerz commented on patch set 3 10/13/16, 10:40

    Still voting now, when I know what this is about ;)
  8. Frank Nägler rebased onto patch set 4 10/13/16, 10:41

  9. TYPO3com voted on patch set 1 V +1 10/13/16, 10:44 Completed build in 10m 07s on Thu, 13 Oct, 12:44 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3705

  10. TYPO3com voted on patch set 2 V +1 10/13/16, 10:46 Completed build in 10m 25s on Thu, 13 Oct, 12:46 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3707

  11. Daniel Goerz updated the commit message in patch set 5 10/13/16, 10:49

  12. Daniel Goerz voted on patch set 5 CR +1 V +1 10/13/16, 10:49

  13. TYPO3com voted on patch set 4 V +1 10/13/16, 10:56 Completed build in 15m 13s on Thu, 13 Oct, 12:56 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3710

  14. TYPO3com voted on patch set 5 V +1 10/13/16, 10:59 Completed build in 10m 19s on Thu, 13 Oct, 12:59 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3712

  15. Frank Nägler voted on patch set 5 CR 0 10/18/16, 12:10

  16. Wouter Wolters voted on patch set 5 CR +2 V +2 10/18/16, 14:17

  17. Gerrit merged patch set 5 10/18/16, 14:17