Review main Merged

50215[TASK] Add RST snippet validation script

Mathias Schreiber CR +2 V +2 Normal +64 −1 updated 10/19/16, 09:35

Commit message

Documentation snippets are now checked for validity.
Every rst file needs:

* An include line at the very top
* A reference to a ticket via "See :issue:`ISSUE_ID`
* An index at the very bottom of the file

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1218

  1. Mathias Schreiber uploaded patch set 1 10/13/16, 14:17

  2. Mathias Schreiber updated the commit message in patch set 2 10/13/16, 14:18

  3. TYPO3com voted on patch set 1 V +1 10/13/16, 14:23 Completed build in 05m 22s on Thu, 13 Oct, 04:23 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3724

  4. TYPO3com voted on patch set 2 V +1 10/13/16, 14:25 Completed build in 06m 53s on Thu, 13 Oct, 04:25 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3725

  5. Susi Moog uploaded patch set 3 10/17/16, 08:57

  6. TYPO3com voted on patch set 3 V -1 10/17/16, 09:02 Completed build in 04m 45s on Mon, 17 Oct, 11:02 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3819

  7. Susi Moog uploaded patch set 4 10/17/16, 09:29

  8. Mathias Schreiber updated the commit message in patch set 5 10/17/16, 09:31

  9. Wouter Wolters commented on patch set 5 10/17/16, 09:34

    Please add this script to typo3/sysext/core/Build/Scripts/checkFilePermissions.sh to let Bamboo run
  10. TYPO3com voted on patch set 4 V -1 10/17/16, 09:35 Completed build in 05m 58s on Mon, 17 Oct, 11:35 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3822

  11. TYPO3com voted on patch set 5 V -1 10/17/16, 09:37 Completed build in 05m 21s on Mon, 17 Oct, 11:37 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3823

  12. Susi Moog uploaded patch set 6 10/17/16, 09:40

  13. TYPO3com voted on patch set 6 V +1 10/17/16, 09:44 Completed build in 03m 58s on Mon, 17 Oct, 11:44 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3826

  14. Wouter Wolters voted on patch set 6 CR +1 10/17/16, 10:42

  15. Wouter Wolters voted on patch set 6 V +1 10/18/16, 14:24

  16. Frank Nägler voted on patch set 6 CR +1 10/19/16, 09:29

  17. Frank Nägler voted on patch set 6 CR +2 V +2 10/19/16, 09:33

  18. Gerrit merged patch set 6 10/19/16, 09:35