Review main Merged

50219[BUGFIX] Side effects from LocalConfiguration in acceptance tests

Christian Kuhn CR +2 V +2 Easy +4 −3 updated 10/13/16, 17:18

Commit message

The functional tests and acceptance test setup is designed to fetch
database settings from a LocalConfiguration if they are not hand
over as environment variables.
The patch restricts the array to use only sub parts from 'DB' of
LocalConfiguration and not more since otherwise funny side effects
are introduced.
This issue was introduced in master (not 7.6) when the test
bootstrap was refactored and prepared for the acceptance tests.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Michael Knabe +1
    • Susi Moog +1
    • Kemal +1
  • Verified V +2
    • Anja Leichsenring +2
    • Michael Knabe +1
    • Susi Moog +1
    • Kemal +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/13/16, 16:40

  2. Michael Knabe voted on patch set 1 CR +1 V +1 10/13/16, 16:43

  3. Kemal voted on patch set 1 CR +1 V +1 10/13/16, 16:46

  4. TYPO3com voted on patch set 1 V +1 10/13/16, 16:48 Completed build in 07m 23s on Thu, 13 Oct, 06:48 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3732

  5. Susi Moog voted on patch set 1 CR +1 V +1 10/13/16, 17:09

  6. Anja Leichsenring voted on patch set 1 CR +2 V +2 10/13/16, 17:18

  7. Gerrit merged patch set 1 10/13/16, 17:18