Review main Merged

50220[TASK] Move code from PageLayoutView to proper class

Georg Ringer CR +2 V +2 Normal +74 −65 updated 02/02/17, 00:29

Commit message

The code is only used in PageInformationController and should
therefore reside in this class instead of PageLayoutView.

Review

  • Code review CR +2
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 913

  1. Georg Ringer uploaded patch set 1 10/13/16, 18:05

  2. TYPO3com voted on patch set 1 V -1 10/13/16, 18:10 Completed build in 05m 00s on Thu, 13 Oct, 08:10 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3737

  3. Georg Ringer uploaded patch set 2 10/14/16, 06:55

  4. TYPO3com voted on patch set 2 V +1 10/14/16, 07:01 Completed build in 06m 00s on Fri, 14 Oct, 09:01 AM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3746

  5. Markus Klein updated the commit message in patch set 3 10/14/16, 08:27

  6. TYPO3com voted on patch set 3 V +1 10/14/16, 08:33 Completed build in 05m 22s on Fri, 14 Oct, 10:33 AM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3747

  7. Oliver Klee commented on patch set 4 10/14/16, 09:26

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V +1 10/14/16, 09:33 Completed build in 06m 59s on Fri, 14 Oct, 11:33 AM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3754

  9. Benni Mack voted on patch set 4 CR +1 10/24/16, 15:09

  10. Anja Leichsenring voted on patch set 4 CR +1 V +1 10/26/16, 10:02

  11. Benni Mack voted on patch set 4 CR +2 V +2 10/26/16, 10:11

  12. Gerrit merged patch set 4 10/26/16, 10:11

  13. Markus Klein commented on patch set 5 02/02/17, 00:29

    PageLayoutView.php:412

    regression here, this is still used. http://forge.typo3.org/issues/79586