Review main Merged

50223[BUGFIX] Fix unset bits in options.alertPopup bitmask

Mathias Brodala CR +2 V +2 Normal +58 −16 updated 02/08/18, 14:24

Commit message

The validation in JsConfirmation did not allow for a value
based on JsConfirmation:ALL with some bits unset.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Reiner Teubner +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Reiner Teubner +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2333

Show 48 earlier messages
  1. Mathias Brodala uploaded patch set 1 10/14/16, 08:31

  2. TYPO3com voted on patch set 1 V -1 10/14/16, 08:36 Completed build in 04m 50s on Fri, 14 Oct, 10:36 AM Test Summary: 2 of 19554 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3748

  3. Mathias Brodala uploaded patch set 2 10/14/16, 08:54

  4. Mathias Brodala uploaded patch set 3 10/14/16, 08:54

  5. TYPO3com voted on patch set 3 V +1 10/14/16, 09:00 Completed build in 06m 00s on Fri, 14 Oct, 11:00 AM Test Summary: 19554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3750

  6. TYPO3com voted on patch set 2 V +1 10/14/16, 09:01 Completed build in 06m 49s on Fri, 14 Oct, 11:01 AM Test Summary: 19554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3749

  7. Mathias Brodala uploaded patch set 4 10/14/16, 09:15

  8. TYPO3com voted on patch set 4 V +1 10/14/16, 09:20 Completed build in 04m 41s on Fri, 14 Oct, 11:20 AM Test Summary: 19554 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3751

  1. Mathias Brodala uploaded patch set 5 10/14/16, 09:22

  2. Mathias Brodala updated the commit message in patch set 6 10/14/16, 09:25

  3. TYPO3com voted on patch set 5 V -1 10/14/16, 09:28 Completed build in 06m 18s on Fri, 14 Oct, 11:28 AM Test Summary: 19556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3752

  4. TYPO3com voted on patch set 6 V -1 10/14/16, 09:32 Completed build in 06m 44s on Fri, 14 Oct, 11:32 AM Test Summary: 19556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3753

  5. Wouter Wolters uploaded patch set 7 10/14/16, 09:36

  6. Wouter Wolters voted on patch set 7 CR +1 V +1 10/14/16, 09:36

  7. TYPO3com voted on patch set 7 V +1 10/14/16, 09:49 Completed build in 12m 16s on Fri, 14 Oct, 11:49 AM Test Summary: 19556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3756

  8. Ruud Silvrants commented on patch set 7 V -1 10/14/16, 12:20

    Still getting the popup with setting 252 in userTs In my situation first the popup occurs and then the function jsConfirmation on backenduserauthentication is invoked while debugging the code.
  9. Benni Mack commented on patch set 7 09/20/17, 14:55

    any progress here?
  10. Mathias Brodala commented on patch set 7 09/21/17, 07:09

    > any progress here? I won't be working on this anytime soon. Anybody else is free to continue though.
  11. Tomas Norre Mikkelsen voted on patch set 7 CR +1 11/30/17, 10:31

  12. Reiner Teubner uploaded patch set 8 02/07/18, 10:34

  13. Reiner Teubner commented on patch set 8 02/07/18, 10:34

    rebase merge conflict
  14. Georg Ringer updated the commit message in patch set 9 02/07/18, 10:37

  15. TYPO3com voted on patch set 8 V +1 02/07/18, 10:40 Completed build in 05m 47s on Wed, 7 Feb, 11:40 AM Test Summary: 30464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19066

  16. TYPO3com voted on patch set 9 V +1 02/07/18, 10:43 Completed build in 06m 44s on Wed, 7 Feb, 11:43 AM Test Summary: 30464 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19067

  17. Mathias Schreiber voted on patch set 9 V +1 CR +1 02/07/18, 16:56

  18. Reiner Teubner voted on patch set 9 V +1 CR +1 02/08/18, 12:47

  19. Susi Moog updated the commit message in patch set 10 02/08/18, 14:02

  20. Mathias Schreiber voted on patch set 10 V +1 CR +1 02/08/18, 14:03

  21. Susi Moog commented on patch set 10 02/08/18, 14:03

    no 7.6, as the whole class is vastly different in 7.6 and I don't see this as a priority bugfix.
  22. Reiner Teubner voted on patch set 10 V +1 CR +1 02/08/18, 14:06

  23. TYPO3com voted on patch set 10 V +1 02/08/18, 14:10 Completed build in 08m 27s on Thu, 8 Feb, 03:10 PM Test Summary: 30467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19133

  24. Susi Moog voted on patch set 10 V +2 CR +2 02/08/18, 14:24

  25. Susi Moog merged patch set 11 02/08/18, 14:24