Review main Merged

50233[TASK] Move ext_icon.png to Resources/Public/Icons for all sysexts

Benni Mack CR +2 V +2 Easy +13 −12 updated 10/19/16, 09:11

Commit message

All extension icons of all system and test extensions shipped with
the core are now located at EXT:.../Resources/Public/Icons/Extension.*
instead of ext_icon.gif.

This is one further step to make it possible to publish only public
assets of an extension to the htdocs/ folder.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Josef Glatz +1
  • Verified V +2
    • Wouter Wolters +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 60

Show 40 more files

Review log 1318

  1. Benni Mack uploaded patch set 1 10/15/16, 19:30

  2. TYPO3com voted on patch set 1 V +1 10/15/16, 19:36 Completed build in 05m 26s on Sat, 15 Oct, 09:36 PM Test Summary: 19552 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3794

  3. Benni Mack uploaded patch set 2 10/18/16, 14:07

  4. TYPO3com voted on patch set 2 V +1 10/18/16, 14:14 Completed build in 06m 23s on Tue, 18 Oct, 04:14 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3892

  5. Wouter Wolters commented on patch set 2 CR -1 10/18/16, 14:39

    typo3/sysext/compatibility7/Resources/Resources/Public/Icons/Extension.png Double Resources folder
  6. Wouter Wolters uploaded patch set 3 10/18/16, 14:41

  7. Wouter Wolters voted on patch set 3 CR +1 V +1 10/18/16, 14:41

  8. TYPO3com voted on patch set 3 V -1 10/18/16, 14:46 Completed build in 05m 05s on Tue, 18 Oct, 04:46 PM Test Summary: 19505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3899

  9. Josef Glatz voted on patch set 3 CR +1 V +1 10/18/16, 16:09

  10. Benni Mack commented on patch set 3 10/19/16, 04:58

    rebasing to see if the tests run through now.
  11. Benni Mack updated the commit message in patch set 4 10/19/16, 04:59

  12. TYPO3com voted on patch set 4 V -1 10/19/16, 05:04 Completed build in 04m 35s on Wed, 19 Oct, 07:04 AM Test Summary: 19505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3906

  13. Wouter Wolters rebased onto patch set 5 10/19/16, 08:56

  14. TYPO3com voted on patch set 5 V +1 10/19/16, 09:02 Completed build in 06m 16s on Wed, 19 Oct, 11:02 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3912

  15. Wouter Wolters voted on patch set 5 CR +1 V +1 10/19/16, 09:10

  16. Josef Glatz voted on patch set 5 CR +1 V +1 10/19/16, 09:10

  17. Wouter Wolters voted on patch set 5 CR +2 V +2 10/19/16, 09:11

  18. Gerrit merged patch set 5 10/19/16, 09:11