50235[BUGFIX] Do not render HTML in Install Tool's flash message
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Frank Nägler +1
-
Verified V +2
- Stefan Neufeind +2
- TYPO3com +1 CI
Issues 2
Files 1
Review log 1618
-
Andreas Kienast uploaded patch set 1 10/16/16, 17:50
-
Andreas Kienast updated the commit message in patch set 2 10/16/16, 17:52
-
TYPO3com voted on patch set 1 V +1 10/16/16, 17:56 Completed build in 05m 35s on Sun, 16 Oct, 07:56 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3808
-
TYPO3com voted on patch set 2 V +1 10/16/16, 17:58 Completed build in 05m 51s on Sun, 16 Oct, 07:58 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3809
-
Nicole Hummel commented on patch set 2 10/16/16, 18:32
I fear this partial is used in an HTML context. Have you checked where this one is used as well? Maybe some messages contain HTML which would break with this patch? -
Andreas Kienast commented on patch set 2 10/16/16, 18:38
Good hint, I'll click through the install tool to check for this. -
Stefan Neufeind commented on patch set 2 CR +1 V +1 10/17/16, 11:36
easy one; only master not 7.6 (I checked that locally) -
Frank Nägler voted on patch set 2 CR +1 10/17/16, 15:58
-
Stefan Neufeind commented on patch set 2 CR +2 V +2 10/17/16, 16:00
easy one; let's have this -
Gerrit merged patch set 2 10/17/16, 16:00
-
Wouter Wolters commented on patch set 3 10/17/16, 16:47
post -1, this change does not have all votes in place! -
Stefan Neufeind commented on patch set 3 10/18/16, 07:47
@Wouter: I see your concerns, and maybe should have handled it different. My background was that it was an easy and obvious fix, easy to test, admin-only and "security-related" (though not critical). And I waited for somebody to take the second look. When Frank responded (core-review not verified, true) that was "okay" in my eyes to have it and not let minor things like this pile up in the review. Could you maybe give a small "post +1 verified"? (please please, with sugar) :-) -
Frank Nägler commented on patch set 3 10/18/16, 08:35
I was testing the patch, as you merged it, I stopped testing this patch in this moment. -
Stefan Neufeind commented on patch set 3 10/18/16, 08:41
Ack, sorry. Learned my lesson. Okay with this patch as is? -
Frank Nägler commented on patch set 3 10/18/16, 08:45
not sure, because I stopped my testing after 2 of ~20 places where this partial is used. I see the merge and stopped working/testing on it. -
Wouter Wolters commented on patch set 3 10/18/16, 09:00
For me this is not ok. We remove XSS for admin user here (which is good). But to not have problems again, we IMO need even more than 2 reviewers to prevent any mistake in this area again. As Frank also said this is used in around 20 places and is not a easy one... -
Stefan Neufeind commented on patch set 3 10/18/16, 09:02
Reverted This patchset was reverted in change: Ic319f148791a3823c2b1baccd0670b67a1cb78f8 -
Stefan Neufeind commented on patch set 3 10/18/16, 09:06
Found at least one small problem where HTML is used for a list which now gets html-escaped. Find the revert at: https://review.typo3.org/50256