Review main Merged

50245[DOC] Document xmlns-carrying node behavior in Fluid

Claus Due CR +2 V +2 Normal +62 −0 updated 10/17/16, 15:58

Commit message

This change documents the fact that xmlns-based
namespace importing works slightly different since Fluid
standalone became the base. Migration docs included.

Review

  • Code review CR +2
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1216

  1. Claus Due uploaded patch set 1 10/17/16, 13:31

  2. Claus Due uploaded patch set 2 10/17/16, 13:32

  3. TYPO3com voted on patch set 1 V +1 10/17/16, 13:36 Completed build in 05m 22s on Mon, 17 Oct, 03:36 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3843

  4. TYPO3com voted on patch set 2 V +1 10/17/16, 13:38 Completed build in 05m 15s on Mon, 17 Oct, 03:38 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3844

  5. Riccardo De Contardi commented on patch set 2 10/17/16, 13:43

    Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:17

    were

    Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:17

    worked

    Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:18

    was **applied only _(not sure)_
  6. Claus Due commented on patch set 3 10/17/16, 14:14

    Published edit on patch set 2.
  7. Claus Due commented on patch set 3 10/17/16, 14:14

    Third occurrence of "would be" is quite congruent, I suppose the others were arguable ;)
  8. Riccardo De Contardi commented on patch set 3 10/17/16, 14:18

    @cd that's why I was not sure... maybe "would have applied"?
  9. TYPO3com voted on patch set 3 V +1 10/17/16, 14:18 Completed build in 04m 34s on Mon, 17 Oct, 04:18 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3845

  10. Susi Moog commented on patch set 3 CR -1 10/17/16, 15:41

    Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:14

    are

    Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:14

    detected

    Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:18

    only apply (?)
  11. Claus Due commented on patch set 4 10/17/16, 15:44

    Published edit on patch set 3.
  12. Claus Due commented on patch set 4 10/17/16, 15:44

    Feel free to edit so you don't have to wait for me ;)
  13. TYPO3com voted on patch set 4 V +1 10/17/16, 15:48 Completed build in 04m 05s on Mon, 17 Oct, 05:48 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3853

  14. Benni Mack voted on patch set 4 CR +1 V +1 10/17/16, 15:57

  15. Susi Moog voted on patch set 4 CR +2 V +2 10/17/16, 15:58

  16. Gerrit merged patch set 4 10/17/16, 15:58