50245[DOC] Document xmlns-carrying node behavior in Fluid
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1216
-
Claus Due uploaded patch set 1 10/17/16, 13:31
-
Claus Due uploaded patch set 2 10/17/16, 13:32
-
TYPO3com voted on patch set 1 V +1 10/17/16, 13:36 Completed build in 05m 22s on Mon, 17 Oct, 03:36 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3843
-
TYPO3com voted on patch set 2 V +1 10/17/16, 13:38 Completed build in 05m 15s on Mon, 17 Oct, 03:38 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3844
-
Riccardo De Contardi commented on patch set 2 10/17/16, 13:43
Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:17workedBreaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:18was **applied only _(not sure)_ -
Claus Due commented on patch set 3 10/17/16, 14:14
Published edit on patch set 2. -
Claus Due commented on patch set 3 10/17/16, 14:14
Third occurrence of "would be" is quite congruent, I suppose the others were arguable ;) -
Riccardo De Contardi commented on patch set 3 10/17/16, 14:18
@cd that's why I was not sure... maybe "would have applied"? -
TYPO3com voted on patch set 3 V +1 10/17/16, 14:18 Completed build in 04m 34s on Mon, 17 Oct, 04:18 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3845
-
Susi Moog commented on patch set 3 CR -1 10/17/16, 15:41
Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:14areBreaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:14detectedBreaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:18only apply (?) -
Claus Due commented on patch set 4 10/17/16, 15:44
Published edit on patch set 3. -
Claus Due commented on patch set 4 10/17/16, 15:44
Feel free to edit so you don't have to wait for me ;) -
TYPO3com voted on patch set 4 V +1 10/17/16, 15:48 Completed build in 04m 05s on Mon, 17 Oct, 05:48 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3853
-
Benni Mack voted on patch set 4 CR +1 V +1 10/17/16, 15:57
-
Susi Moog voted on patch set 4 CR +2 V +2 10/17/16, 15:58
-
Gerrit merged patch set 4 10/17/16, 15:58
Breaking-76155-ViewHelperNamespaceImportsWithXmlnsAreNowSingular.rst:17