Review main Abandoned

50250[BUGFIX] Filelist: Catch exception on non existing storage path

Michael Oehlhof CR 0 V 0 Easy +5 −1 updated 10/22/16, 22:31

Commit message

A Folder in the filelist was not expandable when a Storage
with a non existing base path is configured.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 78

  1. Michael Oehlhof uploaded patch set 1 10/17/16, 20:02

  2. TYPO3com voted on patch set 1 V +1 10/17/16, 20:09 Completed build in 06m 07s on Mon, 17 Oct, 10:09 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3860

  3. Benni Mack commented on patch set 1 10/18/16, 04:38

    cannot reproduce the issue...
  4. Michael Oehlhof commented on patch set 1 10/18/16, 05:56

    Have you tried to reproduce it as described in the forge ticket?
  5. Benni Mack commented on patch set 1 10/18/16, 07:16

    yes
  6. Frank Nägler commented on patch set 1 10/18/16, 07:39

    I can't reproduce the problem too
  7. Christian Kuhn commented on patch set 1 CR -1 10/21/16, 10:34

    I'm unable to reproduce, too. I had the "expand" issue, too, but i think that was fixed with https://review.typo3.org/#/c/50255/
  8. Michael Oehlhof abandoned the change 10/22/16, 22:31

    Looks like it is fixed with https://review.typo3.org/#/c/50255/ which was merged one day after committing my fix.