50255[BUGFIX] Streamline iframe namings for new backend
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Frank Nägler +1
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Riccardo De Contardi +1
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 30
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php+13 −13
- typo3/sysext/backend/Classes/Controller/ClickMenuController.php+3 −2
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/RecordHistory/Main.html+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/backend.js1+23 −3
- typo3/sysext/backend/Resources/Public/JavaScript/ClickMenu.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/BackendUser/ListUserCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/CategoryTreeCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/ElementsBasicCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/General/ModuleMenuCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Page/AddPageInPageModuleCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/Page/PageModuleCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/Scheduler/TasksCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/BookmarkCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/FlushCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/HelpCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/LogoCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SearchCest.php+3 −3
Show 10 more files
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/UsernameOnAvatarCest.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+3 −3
- typo3/sysext/filelist/Resources/Public/JavaScript/FileDelete.js+3 −3
- typo3/sysext/filelist/Resources/Public/JavaScript/FileList.js+3 −3
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+2 −2
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+2 −2
- typo3/sysext/recordlist/Classes/RecordList.php+2 −2
- typo3/sysext/sys_action/Classes/Backend/ToolbarItems/ActionToolbarItem.php+1 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+2 −2
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+1 −1
Review log 2228
Show 3 earlier messages
-
TYPO3com voted on patch set 1 V +1 10/18/16, 09:03 Completed build in 05m 10s on Tue, 18 Oct, 11:03 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3869
-
Frank Nägler voted on patch set 1 V +1 10/18/16, 09:25
-
Frank Nägler commented on patch set 1 V -1 10/18/16, 09:44
clickmenu not working on hide/unhide for pages -
Benni Mack uploaded patch set 2 10/18/16, 10:08
-
Benni Mack commented on patch set 3 10/18/16, 10:12
Published edit on patch set 2. -
TYPO3com voted on patch set 2 V +1 10/18/16, 10:13 Completed build in 04m 54s on Tue, 18 Oct, 12:13 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3874
-
TYPO3com voted on patch set 3 V +1 10/18/16, 10:17 Completed build in 05m 16s on Tue, 18 Oct, 12:17 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3876
-
Benni Mack uploaded patch set 4 10/18/16, 10:20
-
Riccardo De Contardi voted on patch set 4 V +1 10/18/16, 10:24
-
TYPO3com voted on patch set 4 V +1 10/18/16, 10:25 Completed build in 04m 25s on Tue, 18 Oct, 12:25 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3877
-
Benni Mack uploaded patch set 5 10/18/16, 10:26
-
Riccardo De Contardi voted on patch set 5 V +1 10/18/16, 10:31
-
TYPO3com voted on patch set 5 V +1 10/18/16, 10:32 Completed build in 05m 44s on Tue, 18 Oct, 12:32 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3878
-
Christian Kuhn commented on patch set 5 10/18/16, 10:49
backend.js:163please add the word "@deprecated" somewhere - those are used for searching later. -
Frank Nägler commented on patch set 6 10/18/16, 10:52
Published edit on patch set 5. -
Frank Nägler voted on patch set 6 CR +1 V +1 10/18/16, 10:53
-
Christian Kuhn commented on patch set 5 10/18/16, 10:56
green acceptance tests with that patch https://bamboo.typo3.com/browse/CORE-CB-JOB1-164 -
Riccardo De Contardi voted on patch set 6 V +1 10/18/16, 10:56
-
Christian Kuhn voted on patch set 6 CR +1 10/18/16, 10:56
-
Frank Nägler commented on patch set 6 V -1 10/18/16, 10:57
please wait, wouter and I testing a possible bug -
TYPO3com voted on patch set 6 V +1 10/18/16, 10:57 Completed build in 04m 40s on Tue, 18 Oct, 12:57 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3879
-
Christian Kuhn commented on patch set 6 10/18/16, 11:04
patch looks good to my testing. -
Frank Nägler voted on patch set 6 V +1 10/18/16, 11:29
-
Wouter Wolters commented on patch set 6 CR +2 V +2 10/18/16, 11:31
Problem of mine is a bug in 7.6 too, we will fix this later on. -
Gerrit merged patch set 6 10/18/16, 11:31