Review main Merged

50255[BUGFIX] Streamline iframe namings for new backend

Benni Mack CR +2 V +2 Normal +98 −77 updated 10/18/16, 11:31

Commit message

The name of the iframe is now available via top.list_frame
and top.nav_frame instead of top.content.list_frame and
top.content.nav_frame.

All tests are adapted as well.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Frank Nägler +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Riccardo De Contardi +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 30

Show 10 more files

Review log 2228

Show 3 earlier messages
  1. Benni Mack uploaded patch set 1 10/18/16, 08:58

  2. Wouter Wolters voted on patch set 1 CR +1 10/18/16, 09:01

  3. Frank Nägler voted on patch set 1 CR +1 10/18/16, 09:03

  1. TYPO3com voted on patch set 1 V +1 10/18/16, 09:03 Completed build in 05m 10s on Tue, 18 Oct, 11:03 AM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3869

  2. Frank Nägler voted on patch set 1 V +1 10/18/16, 09:25

  3. Frank Nägler commented on patch set 1 V -1 10/18/16, 09:44

    clickmenu not working on hide/unhide for pages
  4. Benni Mack uploaded patch set 2 10/18/16, 10:08

  5. Benni Mack commented on patch set 3 10/18/16, 10:12

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 2 V +1 10/18/16, 10:13 Completed build in 04m 54s on Tue, 18 Oct, 12:13 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3874

  7. TYPO3com voted on patch set 3 V +1 10/18/16, 10:17 Completed build in 05m 16s on Tue, 18 Oct, 12:17 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3876

  8. Benni Mack uploaded patch set 4 10/18/16, 10:20

  9. Riccardo De Contardi voted on patch set 4 V +1 10/18/16, 10:24

  10. TYPO3com voted on patch set 4 V +1 10/18/16, 10:25 Completed build in 04m 25s on Tue, 18 Oct, 12:25 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3877

  11. Benni Mack uploaded patch set 5 10/18/16, 10:26

  12. Riccardo De Contardi voted on patch set 5 V +1 10/18/16, 10:31

  13. TYPO3com voted on patch set 5 V +1 10/18/16, 10:32 Completed build in 05m 44s on Tue, 18 Oct, 12:32 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3878

  14. Christian Kuhn commented on patch set 5 10/18/16, 10:49

    backend.js:163

    please add the word "@deprecated" somewhere - those are used for searching later.
  15. Frank Nägler commented on patch set 6 10/18/16, 10:52

    Published edit on patch set 5.
  16. Frank Nägler voted on patch set 6 CR +1 V +1 10/18/16, 10:53

  17. Christian Kuhn commented on patch set 5 10/18/16, 10:56

    green acceptance tests with that patch https://bamboo.typo3.com/browse/CORE-CB-JOB1-164
  18. Riccardo De Contardi voted on patch set 6 V +1 10/18/16, 10:56

  19. Christian Kuhn voted on patch set 6 CR +1 10/18/16, 10:56

  20. Frank Nägler commented on patch set 6 V -1 10/18/16, 10:57

    please wait, wouter and I testing a possible bug
  21. TYPO3com voted on patch set 6 V +1 10/18/16, 10:57 Completed build in 04m 40s on Tue, 18 Oct, 12:57 PM Test Summary: 19567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3879

  22. Christian Kuhn commented on patch set 6 10/18/16, 11:04

    patch looks good to my testing.
  23. Frank Nägler voted on patch set 6 V +1 10/18/16, 11:29

  24. Wouter Wolters commented on patch set 6 CR +2 V +2 10/18/16, 11:31

    Problem of mine is a bug in 7.6 too, we will fix this later on.
  25. Gerrit merged patch set 6 10/18/16, 11:31